Re: [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

2021-07-08 Thread David Edmondson
On Thursday, 2021-07-08 at 08:22:02 -07, Richard Henderson wrote: > On 7/8/21 12:45 AM, David Edmondson wrote: >> Actually, that's nonsense. With KVM or HVF we have to use the offsets of >> the host CPU, as the hardware won't do anything else, irrespective of >> the general CPU model chosen. >> >

Re: [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

2021-07-08 Thread Richard Henderson
On 7/8/21 12:45 AM, David Edmondson wrote: Actually, that's nonsense. With KVM or HVF we have to use the offsets of the host CPU, as the hardware won't do anything else, irrespective of the general CPU model chosen. To have KVM -> TCG migration work it would be necessary to pass the offsets in t

Re: [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

2021-07-08 Thread David Edmondson
On Wednesday, 2021-07-07 at 11:10:21 +01, David Edmondson wrote: > On Tuesday, 2021-07-06 at 18:09:42 -07, Richard Henderson wrote: > >> On 7/5/21 3:46 AM, David Edmondson wrote: >>> Given that TCG is now the only consumer of X86XSaveArea, move the >>> structure definition and associated offset de

Re: [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

2021-07-07 Thread David Edmondson
On Tuesday, 2021-07-06 at 18:09:42 -07, Richard Henderson wrote: > On 7/5/21 3:46 AM, David Edmondson wrote: >> Given that TCG is now the only consumer of X86XSaveArea, move the >> structure definition and associated offset declarations and checks to a >> TCG specific header. >> >> Signed-off-by:

Re: [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

2021-07-06 Thread Paolo Bonzini
Migration from KVM to TCG is broken anyway. The changing offsets do break migration of a KVM guest from Intel to AMD or vice versa, because of the difference in CPUID. That however is not changed by this patch. Paolo Il mer 7 lug 2021, 03:09 Richard Henderson ha scritto: > On 7/5/21 3:46 AM, Da

Re: [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

2021-07-06 Thread Richard Henderson
On 7/5/21 3:46 AM, David Edmondson wrote: Given that TCG is now the only consumer of X86XSaveArea, move the structure definition and associated offset declarations and checks to a TCG specific header. Signed-off-by: David Edmondson --- target/i386/cpu.h| 57 ---

[RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

2021-07-05 Thread David Edmondson
Given that TCG is now the only consumer of X86XSaveArea, move the structure definition and associated offset declarations and checks to a TCG specific header. Signed-off-by: David Edmondson --- target/i386/cpu.h| 57 target/i386/tcg/fpu_helper.c |