Re: [RFC PATCH 5/9] block/curl: Allow the blocksize to be specified by the user

2020-08-24 Thread David Edmondson
On Monday, 2020-08-24 at 15:19:24 +02, Markus Armbruster wrote: > David Edmondson writes: > >> Rather than a fixed 256kB blocksize, allow the user to specify the >> size used. It must be a non-zero power of two, defaulting to 256kB. > > Nitpick: any power of two is non-zero. Scratch "non-zero".

Re: [RFC PATCH 5/9] block/curl: Allow the blocksize to be specified by the user

2020-08-24 Thread Markus Armbruster
David Edmondson writes: > Rather than a fixed 256kB blocksize, allow the user to specify the > size used. It must be a non-zero power of two, defaulting to 256kB. Nitpick: any power of two is non-zero. Scratch "non-zero". > Signed-off-by: David Edmondson > --- [...] > diff --git a/docs/system

[RFC PATCH 5/9] block/curl: Allow the blocksize to be specified by the user

2020-08-18 Thread David Edmondson
Rather than a fixed 256kB blocksize, allow the user to specify the size used. It must be a non-zero power of two, defaulting to 256kB. Signed-off-by: David Edmondson --- block/curl.c | 73 +-- docs/system/device-url-syntax.rst.inc | 7 +++ qapi/b