Re: [RFC PATCH 3/5] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-07-15 Thread Gerd Hoffmann
> > While being at it: Shouldn't we reserve these port ranges somehow? > > Using an acpi device for example, simliar to fw_cfg? The guest OS > > should better know there is something at those ports ... > > we do it at ACPI level in DSDT, look for comment > /* reserve PCIHP resources */ Ah, good

Re: [RFC PATCH 3/5] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-07-15 Thread Igor Mammedov
On Wed, 15 Jul 2020 08:57:51 +0200 Gerd Hoffmann wrote: > On Mon, Jul 13, 2020 at 04:39:54PM +0200, Igor Mammedov wrote: > > On Thu, 9 Jul 2020 00:46:13 +0200 > > Julia Suvorova wrote: > > > > > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > > > The addresses specified i

Re: [RFC PATCH 3/5] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-07-14 Thread Gerd Hoffmann
On Mon, Jul 13, 2020 at 04:39:54PM +0200, Igor Mammedov wrote: > On Thu, 9 Jul 2020 00:46:13 +0200 > Julia Suvorova wrote: > > > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > > The addresses specified in [1] remain the same to make fewer changes. > > > > [1] docs/spec/acpi

Re: [RFC PATCH 3/5] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-07-14 Thread Igor Mammedov
On Tue, 14 Jul 2020 05:22:20 -0400 "Michael S. Tsirkin" wrote: > On Mon, Jul 13, 2020 at 04:39:54PM +0200, Igor Mammedov wrote: > > On Thu, 9 Jul 2020 00:46:13 +0200 > > Julia Suvorova wrote: > > > > > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > > > The addresses spec

Re: [RFC PATCH 3/5] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-07-14 Thread Michael S. Tsirkin
On Mon, Jul 13, 2020 at 04:39:54PM +0200, Igor Mammedov wrote: > On Thu, 9 Jul 2020 00:46:13 +0200 > Julia Suvorova wrote: > > > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > > The addresses specified in [1] remain the same to make fewer changes. > > > > [1] docs/spec/acpi

Re: [RFC PATCH 3/5] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-07-13 Thread Igor Mammedov
On Thu, 9 Jul 2020 00:46:13 +0200 Julia Suvorova wrote: > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > The addresses specified in [1] remain the same to make fewer changes. > > [1] docs/spec/acpi_pci_hotplug.txt CCing Gerd his opinion on reusing piix4 IO port range for q

[RFC PATCH 3/5] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-07-08 Thread Julia Suvorova
Implement notifications and gpe to support q35 ACPI PCI hot-plug. The addresses specified in [1] remain the same to make fewer changes. [1] docs/spec/acpi_pci_hotplug.txt Signed-off-by: Julia Suvorova --- hw/i386/acpi-build.c | 20 +--- 1 file changed, 13 insertions(+), 7 deleti