Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-21 Thread Michael Roth via
On Wed, Jul 21, 2021 at 03:08:37PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, Jul 20, 2021 at 02:42:12PM -0500, Michael Roth wrote: > >> On Tue, Jul 13, 2021 at 03:46:19PM +0200, Markus Armbruster wrote: > > [...] > > >> > I recommend to do exactly what we've don

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-21 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Jul 20, 2021 at 02:42:12PM -0500, Michael Roth wrote: >> On Tue, Jul 13, 2021 at 03:46:19PM +0200, Markus Armbruster wrote: [...] >> > I recommend to do exactly what we've done before for complex >> > configuration: define it in the QAPI schema, so we can us

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-20 Thread Daniel P . Berrangé
On Tue, Jul 20, 2021 at 02:42:12PM -0500, Michael Roth wrote: > On Tue, Jul 13, 2021 at 03:46:19PM +0200, Markus Armbruster wrote: > > Brijesh Singh writes: > > > > > To launch the SEV-SNP guest, a user can specify up to 8 parameters. > > > Passing all parameters through command line can be diffi

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-20 Thread Michael Roth
On Tue, Jul 13, 2021 at 03:46:19PM +0200, Markus Armbruster wrote: > Brijesh Singh writes: > > > To launch the SEV-SNP guest, a user can specify up to 8 parameters. > > Passing all parameters through command line can be difficult. To simplify > > the launch parameter passing, introduce a .ini-lik

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-14 Thread Brijesh Singh
On 7/13/21 8:46 AM, Markus Armbruster wrote: > Brijesh Singh writes: > >> To launch the SEV-SNP guest, a user can specify up to 8 parameters. >> Passing all parameters through command line can be difficult. To simplify >> the launch parameter passing, introduce a .ini-like config file that can b

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-13 Thread Eric Blake
On Fri, Jul 09, 2021 at 04:55:46PM -0500, Brijesh Singh wrote: > To launch the SEV-SNP guest, a user can specify up to 8 parameters. > Passing all parameters through command line can be difficult. To simplify > the launch parameter passing, introduce a .ini-like config file that can be > used for p

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-13 Thread Brijesh Singh
On 7/12/21 11:24 AM, Daniel P. Berrangé wrote:>> policy: 8 bytes flags: 8 bytes id_block: 96 bytes id_auth: 4096 bytes host_data: 32 bytes gosvw: 16 bytes Only the id_auth parameter is really considered large here. When you say "up to a page size", that implies that the size is actually var

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-13 Thread Markus Armbruster
Brijesh Singh writes: > To launch the SEV-SNP guest, a user can specify up to 8 parameters. > Passing all parameters through command line can be difficult. To simplify > the launch parameter passing, introduce a .ini-like config file that can be > used for passing the parameters to the launch flo

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-12 Thread Daniel P . Berrangé
On Mon, Jul 12, 2021 at 10:56:40AM -0500, Brijesh Singh wrote: > > > On 7/12/21 9:43 AM, Daniel P. Berrangé wrote: > > On Fri, Jul 09, 2021 at 04:55:46PM -0500, Brijesh Singh wrote: > > > To launch the SEV-SNP guest, a user can specify up to 8 parameters. > > > Passing all parameters through comm

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-12 Thread Dr. David Alan Gilbert
* Brijesh Singh (brijesh.si...@amd.com) wrote: > > > On 7/12/21 9:34 AM, Dr. David Alan Gilbert wrote: > > > > > > $ cat snp-launch.init > > > > > > # SNP launch parameters > > > [SEV-SNP] > > > init_flags = 0 > > > policy = 0x1000 > > > id_block = "YWFhYWFhYWFhYWFhYWFhCg==" > > > > Wouldn't t

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-12 Thread Brijesh Singh
On 7/12/21 9:34 AM, Dr. David Alan Gilbert wrote: $ cat snp-launch.init # SNP launch parameters [SEV-SNP] init_flags = 0 policy = 0x1000 id_block = "YWFhYWFhYWFhYWFhYWFhCg==" Wouldn't the 'gosvw' and 'hostdata' also be in there? I did not included all the 8 parameters in the commit mess

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-12 Thread Brijesh Singh
On 7/12/21 9:43 AM, Daniel P. Berrangé wrote: On Fri, Jul 09, 2021 at 04:55:46PM -0500, Brijesh Singh wrote: To launch the SEV-SNP guest, a user can specify up to 8 parameters. Passing all parameters through command line can be difficult. This sentence applies to pretty much everything in Q

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-12 Thread Daniel P . Berrangé
On Fri, Jul 09, 2021 at 04:55:46PM -0500, Brijesh Singh wrote: > To launch the SEV-SNP guest, a user can specify up to 8 parameters. > Passing all parameters through command line can be difficult. This sentence applies to pretty much everything in QEMU and the SEV-SNP example is nowhere near an ex

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-12 Thread Dr. David Alan Gilbert
cc'ing in armbru, since he knows about our command line - have we got a neater way of doing this, or something else that reads config file? Could the existing -readconfig work? Although this is a fairly large chunk of data, I don't think it's any larger than our block device configs on a bad day.

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-11 Thread Dov Murik
On 10/07/2021 0:55, Brijesh Singh wrote: > To launch the SEV-SNP guest, a user can specify up to 8 parameters. > Passing all parameters through command line can be difficult. To simplify > the launch parameter passing, introduce a .ini-like config file that can be > used for passing the paramete

[RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-09 Thread Brijesh Singh
To launch the SEV-SNP guest, a user can specify up to 8 parameters. Passing all parameters through command line can be difficult. To simplify the launch parameter passing, introduce a .ini-like config file that can be used for passing the parameters to the launch flow. The contents of the config f