Re: [RFC PATCH 2/3] dp8393x: Do not amend CRC if it is inhibited (CRCI bit set)

2021-07-03 Thread Finn Thain
On Sat, 3 Jul 2021, Philippe Mathieu-Daudé wrote: > When the CRCI (CRC INHIBIT) bit is set, the 4-byte FCS field > is not transmitted. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/dp8393x.c | 22 ++ > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --g

Re: [RFC PATCH 2/3] dp8393x: Do not amend CRC if it is inhibited (CRCI bit set)

2021-07-03 Thread Philippe Mathieu-Daudé
On Sat, Jul 3, 2021 at 6:32 PM BALATON Zoltan wrote: > On Sat, 3 Jul 2021, Philippe Mathieu-Daudé wrote: > > When the CRCI (CRC INHIBIT) bit is set, the 4-byte FCS field > > is not transmitted. > > You say when CRCI is 1 then no checksum... > > > > > Signed-off-by: Philippe Mathieu-Daudé > > ---

Re: [RFC PATCH 2/3] dp8393x: Do not amend CRC if it is inhibited (CRCI bit set)

2021-07-03 Thread BALATON Zoltan
On Sat, 3 Jul 2021, Philippe Mathieu-Daudé wrote: When the CRCI (CRC INHIBIT) bit is set, the 4-byte FCS field is not transmitted. You say when CRCI is 1 then no checksum... Signed-off-by: Philippe Mathieu-Daudé --- hw/net/dp8393x.c | 22 ++ 1 file changed, 14 insertions(

[RFC PATCH 2/3] dp8393x: Do not amend CRC if it is inhibited (CRCI bit set)

2021-07-03 Thread Philippe Mathieu-Daudé
When the CRCI (CRC INHIBIT) bit is set, the 4-byte FCS field is not transmitted. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/dp8393x.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 99e179a5e86..dee823640