Re: [RFC PATCH 12/15] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub

2020-11-06 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 11/5/20 6:51 PM, Alex Bennée wrote: >> We should never build something that calls this without having it. > > "because ..."? xen-all.c is only built when we have CONFIG_XEN which also gates the only call-site in xen-console.c > > Reviewed-by: Philippe M

Re: [RFC PATCH 12/15] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub

2020-11-05 Thread Philippe Mathieu-Daudé
On 11/5/20 6:51 PM, Alex Bennée wrote: > We should never build something that calls this without having it. "because ..."? Reviewed-by: Philippe Mathieu-Daudé > > Signed-off-by: Alex Bennée > --- > stubs/xen-hw-stub.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/stubs/xen-hw-

[RFC PATCH 12/15] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub

2020-11-05 Thread Alex Bennée
We should never build something that calls this without having it. Signed-off-by: Alex Bennée --- stubs/xen-hw-stub.c | 4 1 file changed, 4 deletions(-) diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c index 2ea8190921..15f3921a76 100644 --- a/stubs/xen-hw-stub.c +++ b/stubs/xen-hw-