Re: [RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls

2022-09-09 Thread Emanuele Giuseppe Esposito
Am 27/08/2022 um 23:03 schrieb Peter Xu: > On Fri, Aug 26, 2022 at 10:13:47AM -0400, Peter Xu wrote: >> On Fri, Aug 26, 2022 at 03:53:09PM +0200, Emanuele Giuseppe Esposito wrote: >>> What do you mean "will empty all regions with those listeners"? >>> But yes theoretically vhost-vdpa and physmem

Re: [RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls

2022-08-27 Thread Peter Xu
On Fri, Aug 26, 2022 at 10:13:47AM -0400, Peter Xu wrote: > On Fri, Aug 26, 2022 at 03:53:09PM +0200, Emanuele Giuseppe Esposito wrote: > > What do you mean "will empty all regions with those listeners"? > > But yes theoretically vhost-vdpa and physmem have commit callbacks that > > are independent

Re: [RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls

2022-08-26 Thread Peter Xu
On Fri, Aug 26, 2022 at 03:53:09PM +0200, Emanuele Giuseppe Esposito wrote: > What do you mean "will empty all regions with those listeners"? > But yes theoretically vhost-vdpa and physmem have commit callbacks that > are independent from whether region_add or other callbacks have been called. > Fo

Re: [RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls

2022-08-26 Thread Emanuele Giuseppe Esposito
Am 18/08/2022 um 21:34 schrieb Peter Xu: > On Tue, Aug 16, 2022 at 06:12:49AM -0400, Emanuele Giuseppe Esposito wrote: >> kvm listeners now need ->commit callback in order to actually send >> the ioctl to the hypervisor. Therefore, add missing callers around >> address_space_set_flatview(), whic

Re: [RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls

2022-08-18 Thread Peter Xu
On Tue, Aug 16, 2022 at 06:12:49AM -0400, Emanuele Giuseppe Esposito wrote: > kvm listeners now need ->commit callback in order to actually send > the ioctl to the hypervisor. Therefore, add missing callers around > address_space_set_flatview(), which in turn calls > address_space_update_topology_p

[RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls

2022-08-16 Thread Emanuele Giuseppe Esposito
kvm listeners now need ->commit callback in order to actually send the ioctl to the hypervisor. Therefore, add missing callers around address_space_set_flatview(), which in turn calls address_space_update_topology_pass() which calls ->region_* and ->log_* callbacks. Using MEMORY_LISTENER_CALL_GLOB