Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-14 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Sep 06, 2024 at 10:52:53AM +0100, Peter Maydell wrote: >> On Fri, 6 Sept 2024 at 09:14, Daniel P. Berrangé wrote: >> > >> > On Fri, Sep 06, 2024 at 08:16:31AM +0200, Thomas Huth wrote: >> > > On 05/09/2024 23.03, Fabiano Rosas wrote: >> > > > Hi, >> > > > >>

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-13 Thread Thomas Huth
On 13/09/2024 13.46, Peter Maydell wrote: On Fri, 13 Sept 2024 at 12:29, Markus Armbruster wrote: Peter Maydell writes: Specifically, if you don't disable the error-exit when qtest is in use, then the generic qom-test tests which say "can we at least instantiate every machine?" will fail, be

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-13 Thread Daniel P . Berrangé
On Fri, Sep 06, 2024 at 10:52:53AM +0100, Peter Maydell wrote: > On Fri, 6 Sept 2024 at 09:14, Daniel P. Berrangé wrote: > > > > On Fri, Sep 06, 2024 at 08:16:31AM +0200, Thomas Huth wrote: > > > On 05/09/2024 23.03, Fabiano Rosas wrote: > > > > Hi, > > > > > > > > This series silences QEMU stderr

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-13 Thread Peter Maydell
On Fri, 13 Sept 2024 at 12:29, Markus Armbruster wrote: > > Peter Maydell writes: > > Specifically, if you don't disable the error-exit when qtest > > is in use, then the generic qom-test tests which say "can we > > at least instantiate every machine?" will fail, because they > > assume that "qem

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-13 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 13 Sept 2024 at 11:02, Markus Armbruster wrote: >> >> Fabiano Rosas writes: >> > I could add error/warn variants that are noop in case qtest is >> > enabled. It would, however, lead to this pattern which is discouraged by >> > the error.h documentation (+Cc Marku

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-13 Thread Peter Maydell
On Fri, 13 Sept 2024 at 11:02, Markus Armbruster wrote: > > Fabiano Rosas writes: > > I could add error/warn variants that are noop in case qtest is > > enabled. It would, however, lead to this pattern which is discouraged by > > the error.h documentation (+Cc Markus for advice): > > > > before:

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-13 Thread Markus Armbruster
Fabiano Rosas writes: > Peter Maydell writes: > >> On Fri, 6 Sept 2024 at 09:14, Daniel P. Berrangé wrote: >>> >>> On Fri, Sep 06, 2024 at 08:16:31AM +0200, Thomas Huth wrote: >>> > On 05/09/2024 23.03, Fabiano Rosas wrote: >>> > > Hi, >>> > > >>> > > This series silences QEMU stderr unless the

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-06 Thread Fabiano Rosas
Peter Maydell writes: > On Fri, 6 Sept 2024 at 09:14, Daniel P. Berrangé wrote: >> >> On Fri, Sep 06, 2024 at 08:16:31AM +0200, Thomas Huth wrote: >> > On 05/09/2024 23.03, Fabiano Rosas wrote: >> > > Hi, >> > > >> > > This series silences QEMU stderr unless the QTEST_LOG variable is set >> > >

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-06 Thread Peter Maydell
On Fri, 6 Sept 2024 at 09:14, Daniel P. Berrangé wrote: > > On Fri, Sep 06, 2024 at 08:16:31AM +0200, Thomas Huth wrote: > > On 05/09/2024 23.03, Fabiano Rosas wrote: > > > Hi, > > > > > > This series silences QEMU stderr unless the QTEST_LOG variable is set > > > and silences -qtest-log unless bo

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-06 Thread Daniel P . Berrangé
On Fri, Sep 06, 2024 at 08:16:31AM +0200, Thomas Huth wrote: > On 05/09/2024 23.03, Fabiano Rosas wrote: > > Hi, > > > > This series silences QEMU stderr unless the QTEST_LOG variable is set > > and silences -qtest-log unless both QTEST_LOG and gtest's --verbose > > flag is passed. > > > > This w

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-05 Thread Thomas Huth
On 05/09/2024 23.03, Fabiano Rosas wrote: Hi, This series silences QEMU stderr unless the QTEST_LOG variable is set and silences -qtest-log unless both QTEST_LOG and gtest's --verbose flag is passed. This was motivated by Peter Maydell's ask to suppress deprecation warn_report messages from the

[RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-05 Thread Fabiano Rosas
Hi, This series silences QEMU stderr unless the QTEST_LOG variable is set and silences -qtest-log unless both QTEST_LOG and gtest's --verbose flag is passed. This was motivated by Peter Maydell's ask to suppress deprecation warn_report messages from the migration-tests and by my own frustration o