Re: [RFC PATCH-for-8.0] hw: Avoid using inlined functions with external linkage

2022-12-16 Thread Philippe Mathieu-Daudé
On 8/12/22 17:27, Peter Maydell wrote: On Thu, 8 Dec 2022 at 16:11, Philippe Mathieu-Daudé wrote: When using Clang ("Apple clang version 14.0.0 (clang-1400.0.29.202)") and building with -Wall we get: hw/arm/smmu-common.c:173:33: warning: static function 'smmu_hash_remove_by_asid_iova' is

Re: [RFC PATCH-for-8.0] hw: Avoid using inlined functions with external linkage

2022-12-08 Thread Peter Maydell
On Thu, 8 Dec 2022 at 16:11, Philippe Mathieu-Daudé wrote: > > When using Clang ("Apple clang version 14.0.0 (clang-1400.0.29.202)") > and building with -Wall we get: > > hw/arm/smmu-common.c:173:33: warning: static function > 'smmu_hash_remove_by_asid_iova' is used in an inline function with e

[RFC PATCH-for-8.0] hw: Avoid using inlined functions with external linkage

2022-12-08 Thread Philippe Mathieu-Daudé
When using Clang ("Apple clang version 14.0.0 (clang-1400.0.29.202)") and building with -Wall we get: hw/arm/smmu-common.c:173:33: warning: static function 'smmu_hash_remove_by_asid_iova' is used in an inline function with external linkage [-Wstatic-in-inline] hw/arm/smmu-common.h:170:1: not