Re: [RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-25 Thread Si-Wei Liu
On 3/25/2022 12:59 AM, Jason Wang wrote: On Fri, Mar 25, 2022 at 3:02 PM Si-Wei Liu wrote: On 3/21/2022 8:47 PM, Jason Wang wrote: On Sat, Mar 19, 2022 at 12:14 PM Si-Wei Liu wrote: With MQ enabled vdpa device and non-MQ supporting guest e.g. booting vdpa with mq=on over OVMF of single

Re: [RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-25 Thread Jason Wang
On Fri, Mar 25, 2022 at 3:02 PM Si-Wei Liu wrote: > > > > On 3/21/2022 8:47 PM, Jason Wang wrote: > > On Sat, Mar 19, 2022 at 12:14 PM Si-Wei Liu wrote: > >> With MQ enabled vdpa device and non-MQ supporting guest e.g. > >> booting vdpa with mq=on over OVMF of single vqp, it's easy > >> to hit as

Re: [RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-25 Thread Si-Wei Liu
On 3/21/2022 8:47 PM, Jason Wang wrote: On Sat, Mar 19, 2022 at 12:14 PM Si-Wei Liu wrote: With MQ enabled vdpa device and non-MQ supporting guest e.g. booting vdpa with mq=on over OVMF of single vqp, it's easy to hit assert failure as the following: ../hw/virtio/vhost-vdpa.c:560: vhost_vdp

Re: [RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-21 Thread Jason Wang
On Sat, Mar 19, 2022 at 12:14 PM Si-Wei Liu wrote: > > With MQ enabled vdpa device and non-MQ supporting guest e.g. > booting vdpa with mq=on over OVMF of single vqp, it's easy > to hit assert failure as the following: > > ../hw/virtio/vhost-vdpa.c:560: vhost_vdpa_get_vq_index: Assertion `idx >=

[RFC PATCH] vhost_net: should not use max_queue_pairs for non-mq guest

2022-03-18 Thread Si-Wei Liu
With MQ enabled vdpa device and non-MQ supporting guest e.g. booting vdpa with mq=on over OVMF of single vqp, it's easy to hit assert failure as the following: ../hw/virtio/vhost-vdpa.c:560: vhost_vdpa_get_vq_index: Assertion `idx >= dev->vq_index && idx < dev->vq_index + dev->nvqs' failed. 0 0