Re: [RFC PATCH] tests/qtest: properly initialise the vring used idx

2022-04-07 Thread Eric Auger
Hi Alex, On 4/6/22 7:33 PM, Alex Bennée wrote: > Eric noticed while attempting to enable the vhost-user-blk-test for > Aarch64 that that things didn't work unless he put in a dummy > guest_malloc() at the start of the test. Without it > qvirtio_wait_used_elem() would assert when it reads a junk va

Re: [RFC PATCH] tests/qtest: properly initialise the vring used idx

2022-04-07 Thread Alex Bennée
Peter Maydell writes: > On Wed, 6 Apr 2022 at 21:07, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> > Guest memory is generally zero at startup. Do we manage to >> > hit the bit of memory at the start of the virt machine's RAM >> > where we store the DTB ? (As you say, initializing the

Re: [RFC PATCH] tests/qtest: properly initialise the vring used idx

2022-04-07 Thread Stefan Hajnoczi
On Wed, Apr 06, 2022 at 06:33:56PM +0100, Alex Bennée wrote: > Eric noticed while attempting to enable the vhost-user-blk-test for > Aarch64 that that things didn't work unless he put in a dummy > guest_malloc() at the start of the test. Without it > qvirtio_wait_used_elem() would assert when it re

Re: [RFC PATCH] tests/qtest: properly initialise the vring used idx

2022-04-06 Thread Peter Maydell
On Wed, 6 Apr 2022 at 21:07, Alex Bennée wrote: > > > Peter Maydell writes: > > Guest memory is generally zero at startup. Do we manage to > > hit the bit of memory at the start of the virt machine's RAM > > where we store the DTB ? (As you say, initializing the data > > structures is the right t

Re: [RFC PATCH] tests/qtest: properly initialise the vring used idx

2022-04-06 Thread Alex Bennée
Peter Maydell writes: > On Wed, 6 Apr 2022 at 18:36, Alex Bennée wrote: >> >> Eric noticed while attempting to enable the vhost-user-blk-test for >> Aarch64 that that things didn't work unless he put in a dummy >> guest_malloc() at the start of the test. Without it >> qvirtio_wait_used_elem()

Re: [RFC PATCH] tests/qtest: properly initialise the vring used idx

2022-04-06 Thread Peter Maydell
On Wed, 6 Apr 2022 at 18:36, Alex Bennée wrote: > > Eric noticed while attempting to enable the vhost-user-blk-test for > Aarch64 that that things didn't work unless he put in a dummy > guest_malloc() at the start of the test. Without it > qvirtio_wait_used_elem() would assert when it reads a junk

[RFC PATCH] tests/qtest: properly initialise the vring used idx

2022-04-06 Thread Alex Bennée
Eric noticed while attempting to enable the vhost-user-blk-test for Aarch64 that that things didn't work unless he put in a dummy guest_malloc() at the start of the test. Without it qvirtio_wait_used_elem() would assert when it reads a junk value for idx resulting in: qvirtqueue_get_buf: idx:240