Re: [RFC PATCH] target/ppc: Remove xscmpnedp instruction

2022-01-10 Thread Cédric Le Goater
On 1/10/22 18:57, Victor Colombo wrote: On 10/01/2022 12:02, Cédric Le Goater wrote: On 1/6/22 12:23, Víctor Colombo wrote: xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch removes this instruction as it was not in the final version of v3.0. Could please resend on top of the

Re: [RFC PATCH] target/ppc: Remove xscmpnedp instruction

2022-01-10 Thread Victor Colombo
On 10/01/2022 12:02, Cédric Le Goater wrote: On 1/6/22 12:23, Víctor Colombo wrote: xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch removes this instruction as it was not in the final version of v3.0. Could please resend on top of the VSX combo patchset ? Absolutely! I wil

Re: [RFC PATCH] target/ppc: Remove xscmpnedp instruction

2022-01-10 Thread Cédric Le Goater
On 1/6/22 12:23, Víctor Colombo wrote: xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch removes this instruction as it was not in the final version of v3.0. Could please resend on top of the VSX combo patchset ? Thanks, C.

Re: [RFC PATCH] target/ppc: Remove xscmpnedp instruction

2022-01-06 Thread David Gibson
On Thu, Jan 06, 2022 at 02:02:01PM +0100, Greg Kurz wrote: > On Thu, 6 Jan 2022 13:21:46 +0100 > Cédric Le Goater wrote: > > > On 1/6/22 12:23, Víctor Colombo wrote: > > > xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch > > > removes this instruction as it was not in the final ve

Re: [RFC PATCH] target/ppc: Remove xscmpnedp instruction

2022-01-06 Thread Richard Henderson
On 1/6/22 3:23 AM, Víctor Colombo wrote: xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch removes this instruction as it was not in the final version of v3.0. RFC to know if you think this is the correct approach. Should be fine. I assume the -cpu power9 that we intend to emul

Re: [RFC PATCH] target/ppc: Remove xscmpnedp instruction

2022-01-06 Thread Greg Kurz
On Thu, 6 Jan 2022 13:21:46 +0100 Cédric Le Goater wrote: > On 1/6/22 12:23, Víctor Colombo wrote: > > xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch > > removes this instruction as it was not in the final version of v3.0. > > > > RFC to know if you think this is the correct ap

Re: [RFC PATCH] target/ppc: Remove xscmpnedp instruction

2022-01-06 Thread Cédric Le Goater
On 1/6/22 12:23, Víctor Colombo wrote: xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch removes this instruction as it was not in the final version of v3.0. RFC to know if you think this is the correct approach. Usually we deprecate a feature for a minimum of two releases befor

[RFC PATCH] target/ppc: Remove xscmpnedp instruction

2022-01-06 Thread Víctor Colombo
xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch removes this instruction as it was not in the final version of v3.0. RFC to know if you think this is the correct approach. Signed-off-by: Víctor Colombo --- target/ppc/fpu_helper.c | 1 - target/ppc/helper.h