Re: [RFC PATCH] hw/net/can: clean-up unnecessary includes

2024-12-09 Thread Pierrick Bouvier
On 12/9/24 02:06, Alex Bennée wrote: The event_notifier, thread and socket includes look like copy and paste of standard headers. None of the canbus devices use chardev although some relied on chardev to bring in bitops and byte swapping headers. In this case include them directly. Signed-off-by

Re: [RFC PATCH] hw/net/can: clean-up unnecessary includes

2024-12-09 Thread Philippe Mathieu-Daudé
On 9/12/24 12:23, Pavel Pisa wrote: Hello Alex, On Monday 09 of December 2024 11:06:35 Alex Bennée wrote: The event_notifier, thread and socket includes look like copy and paste of standard headers. None of the canbus devices use chardev although some relied on chardev to bring in bitops and by

Re: [RFC PATCH] hw/net/can: clean-up unnecessary includes

2024-12-09 Thread Pavel Pisa
Hello Alex, On Monday 09 of December 2024 11:06:35 Alex Bennée wrote: > The event_notifier, thread and socket includes look like copy and > paste of standard headers. None of the canbus devices use chardev > although some relied on chardev to bring in bitops and byte swapping > headers. In this ca

[RFC PATCH] hw/net/can: clean-up unnecessary includes

2024-12-09 Thread Alex Bennée
The event_notifier, thread and socket includes look like copy and paste of standard headers. None of the canbus devices use chardev although some relied on chardev to bring in bitops and byte swapping headers. In this case include them directly. Signed-off-by: Alex Bennée --- hw/net/can/can_kvas