Re: [RFC PATCH] accel/tcg: clear all TBs from a page when it is written to

2024-08-20 Thread Richard Henderson
On 8/14/24 16:09, Nicholas Piggin wrote: @@ -1107,6 +1107,9 @@ tb_invalidate_phys_page_range__locked(struct page_collection *pages, TranslationBlock *current_tb = retaddr ? tcg_tb_lookup(retaddr) : NULL; #endif /* TARGET_HAS_PRECISE_SMC */ +start &= TARGET_PAGE_MASK; +last

Re: [RFC PATCH] accel/tcg: clear all TBs from a page when it is written to

2024-08-13 Thread Nicholas Piggin
On Mon Aug 12, 2024 at 11:25 AM AEST, Richard Henderson wrote: > On 8/9/24 17:47, Nicholas Piggin wrote: > > This is not a clean patch, but does fix a problem I hit with TB > > invalidation due to the target software writing to memory with TBs. > > > > Lockup messages are triggering in Linux due t

Re: [RFC PATCH] accel/tcg: clear all TBs from a page when it is written to

2024-08-11 Thread Richard Henderson
On 8/9/24 17:47, Nicholas Piggin wrote: This is not a clean patch, but does fix a problem I hit with TB invalidation due to the target software writing to memory with TBs. Lockup messages are triggering in Linux due to page clearing taking a long time when a code page has been freed, because it

Re: [RFC PATCH] accel/tcg: clear all TBs from a page when it is written to

2024-08-09 Thread Philippe Mathieu-Daudé
(Widening Cc list) On 9/8/24 09:47, Nicholas Piggin wrote: This is not a clean patch, but does fix a problem I hit with TB invalidation due to the target software writing to memory with TBs. Lockup messages are triggering in Linux due to page clearing taking a long time when a code page has bee

[RFC PATCH] accel/tcg: clear all TBs from a page when it is written to

2024-08-09 Thread Nicholas Piggin
This is not a clean patch, but does fix a problem I hit with TB invalidation due to the target software writing to memory with TBs. Lockup messages are triggering in Linux due to page clearing taking a long time when a code page has been freed, because it takes a lot of notdirty notifiers, which m