Re: [RFC PATCH] accel/tcg: avoid re-translating one-shot instructions

2021-04-15 Thread Peter Maydell
On Thu, 15 Apr 2021 at 19:13, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Thu, 15 Apr 2021 at 17:25, Alex Bennée wrote: > >> > >> By definition a single instruction is capable of being an IO > >> instruction. This avoids a problem of triggering a cpu_io_recompile on > >> a non-record

Re: [RFC PATCH] accel/tcg: avoid re-translating one-shot instructions

2021-04-15 Thread Alex Bennée
Peter Maydell writes: > On Thu, 15 Apr 2021 at 17:25, Alex Bennée wrote: >> >> By definition a single instruction is capable of being an IO >> instruction. This avoids a problem of triggering a cpu_io_recompile on >> a non-recorded translation which then fails because it expects >> tcg_tb_look

Re: [RFC PATCH] accel/tcg: avoid re-translating one-shot instructions

2021-04-15 Thread Richard Henderson
On 4/15/21 9:24 AM, Alex Bennée wrote: By definition a single instruction is capable of being an IO instruction. This avoids a problem of triggering a cpu_io_recompile on a non-recorded translation which then fails because it expects tcg_tb_lookup() to succeed unconditionally. The normal use case

Re: [RFC PATCH] accel/tcg: avoid re-translating one-shot instructions

2021-04-15 Thread Peter Maydell
On Thu, 15 Apr 2021 at 17:25, Alex Bennée wrote: > > By definition a single instruction is capable of being an IO > instruction. This avoids a problem of triggering a cpu_io_recompile on > a non-recorded translation which then fails because it expects > tcg_tb_lookup() to succeed unconditionally.

[RFC PATCH] accel/tcg: avoid re-translating one-shot instructions

2021-04-15 Thread Alex Bennée
By definition a single instruction is capable of being an IO instruction. This avoids a problem of triggering a cpu_io_recompile on a non-recorded translation which then fails because it expects tcg_tb_lookup() to succeed unconditionally. The normal use case requires a TB to be able to resolve mach