Re: [RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-07-21 Thread Jose R. Ziviani
On Wed, Jul 21, 2021 at 10:57:37AM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 21, 2021 at 11:54:45AM +0200, Gerd Hoffmann wrote: > > > ObjectClass *module_object_class_by_name(const char *typename) > > > { > > > ObjectClass *oc; > > > @@ -1031,8 +1049,20 @@ ObjectClass *module_object_cla

Re: [RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 11:54:45AM +0200, Gerd Hoffmann wrote: > > ObjectClass *module_object_class_by_name(const char *typename) > > { > > ObjectClass *oc; > > @@ -1031,8 +1049,20 @@ ObjectClass *module_object_class_by_name(const char > > *typename) > > oc = object_class_by_name(typen

Re: [RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-07-21 Thread Gerd Hoffmann
> ObjectClass *module_object_class_by_name(const char *typename) > { > ObjectClass *oc; > @@ -1031,8 +1049,20 @@ ObjectClass *module_object_class_by_name(const char > *typename) > oc = object_class_by_name(typename); > #ifdef CONFIG_MODULES > if (!oc) { > +char *module_na

Re: [RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-07-19 Thread Claudio Fontana
On 7/20/21 3:26 AM, Jose R. Ziviani wrote: > On Mon, Jul 19, 2021 at 05:29:49PM +0200, Claudio Fontana wrote: >> On 7/1/21 1:27 AM, Jose R. Ziviani wrote: >>> module_object_class_by_name() calls module_load_qom_one if the object >>> is provided by a dynamically linked library. Such library might no

Re: [RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-07-19 Thread Jose R. Ziviani
On Mon, Jul 19, 2021 at 05:29:49PM +0200, Claudio Fontana wrote: > On 7/1/21 1:27 AM, Jose R. Ziviani wrote: > > module_object_class_by_name() calls module_load_qom_one if the object > > is provided by a dynamically linked library. Such library might not be > > available at this moment - for instan

Re: [RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-07-19 Thread Claudio Fontana
On 7/1/21 1:27 AM, Jose R. Ziviani wrote: > module_object_class_by_name() calls module_load_qom_one if the object > is provided by a dynamically linked library. Such library might not be > available at this moment - for instance, it can be a package not yet > installed. Thus, instead of assert erro

[RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-06-30 Thread Jose R. Ziviani
module_object_class_by_name() calls module_load_qom_one if the object is provided by a dynamically linked library. Such library might not be available at this moment - for instance, it can be a package not yet installed. Thus, instead of assert error messages, this patch outputs more friendly messa