Re: [RFC 2/3] x86: cphp: prevent guest crash on CPU hotplug when broadcast SMI is in use

2020-07-20 Thread Laszlo Ersek
On 07/17/20 14:57, Igor Mammedov wrote: > On Tue, 14 Jul 2020 12:56:50 +0200 > Laszlo Ersek wrote: > >> On 07/10/20 18:17, Igor Mammedov wrote: > [...] > >>> @@ -1508,6 +1508,17 @@ static void pc_cpu_pre_plug(HotplugHandler >>> *hotplug_dev, >>> return; >>> } >>> >>> +if (pcms

Re: [RFC 2/3] x86: cphp: prevent guest crash on CPU hotplug when broadcast SMI is in use

2020-07-17 Thread Igor Mammedov
On Tue, 14 Jul 2020 12:56:50 +0200 Laszlo Ersek wrote: > On 07/10/20 18:17, Igor Mammedov wrote: [...] > > @@ -1508,6 +1508,17 @@ static void pc_cpu_pre_plug(HotplugHandler > > *hotplug_dev, > > return; > > } > > > > +if (pcms->acpi_dev) { > > +Error *local_err = NULL;

Re: [RFC 2/3] x86: cphp: prevent guest crash on CPU hotplug when broadcast SMI is in use

2020-07-14 Thread Laszlo Ersek
On 07/10/20 18:17, Igor Mammedov wrote: > There were reports of guest crash on CPU hotplug, when using q35 machine > type and QVMF with Secure Boot, due to hotplugged CPU trying to process SMI (1) typo: s/QVMF/OVMF/ please (2) Please replace "Secure Boot" with "SMM". In everyday practice it's OK

[RFC 2/3] x86: cphp: prevent guest crash on CPU hotplug when broadcast SMI is in use

2020-07-10 Thread Igor Mammedov
There were reports of guest crash on CPU hotplug, when using q35 machine type and QVMF with Secure Boot, due to hotplugged CPU trying to process SMI at default SMI handler location without it being relocated by firmware first. Fix it by refusing hotplug if firmware hasn't negotiatiad CPU hotplug S