On Thu, Dec 05, 2024 at 10:20:47PM +0100, Paolo Bonzini wrote:
> Date: Thu, 5 Dec 2024 22:20:47 +0100
> From: Paolo Bonzini
> Subject: Re: [RFC 11/13] rust/timer/hpet: add basic HPET timer & state
>
> On Thu, Dec 5, 2024 at 9:23 PM Paolo Bonzini wrote:
> > > +
> > +use qemu_api::{
> > +bindings::*,
>
> Let's avoid bindings::*.
Sure.
> > +self.qemu_timer = Box::new(HPETState::timer_new_ns(
>
> Oh! I noticed now that while your API is called timer_new_ns, it is actually
> the same as timer_init_full. Let's call it init_full() then.
Sure,
On Thu, Dec 5, 2024 at 9:23 PM Paolo Bonzini wrote:
> > +/// Instance id (HPET timer block ID).
> > +hpet_id: BqlCell,
> > +}
> > +
> Like flags this does not need to be a cell.
Well, this *should not* need to be a cell (ideally fw_cfg would call a
C function to generate FW_CFG_HPET) but
On 12/5/24 07:07, Zhao Liu wrote:
Add the HPETTimer and HPETState (HPET timer block), along with their
basic methods and register definitions.
This is in preparation for supporting the QAPI interfaces.
Note, wrap all items in HPETState that may be changed in the callback
called by C code into t
Add the HPETTimer and HPETState (HPET timer block), along with their
basic methods and register definitions.
This is in preparation for supporting the QAPI interfaces.
Note, wrap all items in HPETState that may be changed in the callback
called by C code into the BqlCell/BqlRefCell.
Signed-off-b
