Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Max Reitz
On 04.11.19 16:49, Alberto Garcia wrote: > On Mon 04 Nov 2019 04:14:56 PM CET, Max Reitz wrote: > No, what I meant was that the original problem that led to c8bb23cbdbe would go away. >>> >>> Ah, right. Not quite, according to my numbers: >>> >>> |--++

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Alberto Garcia
On Mon 04 Nov 2019 04:14:56 PM CET, Max Reitz wrote: >>> No, what I meant was that the original problem that led to >>> c8bb23cbdbe would go away. >> >> Ah, right. Not quite, according to my numbers: >> >> |--++-+-| >> | Cluster size | subc

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Max Reitz
On 04.11.19 16:12, Alberto Garcia wrote: > On Mon 04 Nov 2019 03:25:12 PM CET, Max Reitz wrote: >> So, it's obvious that c8bb23cbdbe32f5c326 is significant for 1M >> cluster-size, even on rotational disk, which means that previous >> assumption about calling handle_alloc_space() only fo

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Alberto Garcia
On Mon 04 Nov 2019 03:25:12 PM CET, Max Reitz wrote: > So, it's obvious that c8bb23cbdbe32f5c326 is significant for 1M > cluster-size, even on rotational disk, which means that previous > assumption about calling handle_alloc_space() only for ssd is wrong, > we need smarter heuristi

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Max Reitz
On 04.11.19 15:03, Alberto Garcia wrote: > On Fri 25 Oct 2019 04:19:30 PM CEST, Max Reitz wrote: So, it's obvious that c8bb23cbdbe32f5c326 is significant for 1M cluster-size, even on rotational disk, which means that previous assumption about calling handle_alloc_space() only for ssd

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-11-04 Thread Alberto Garcia
On Fri 25 Oct 2019 04:19:30 PM CEST, Max Reitz wrote: >>> So, it's obvious that c8bb23cbdbe32f5c326 is significant for 1M >>> cluster-size, even on rotational disk, which means that previous >>> assumption about calling handle_alloc_space() only for ssd is wrong, >>> we need smarter heuristics.. >>

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Max Reitz
On 29.10.19 13:19, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 15:11, Max Reitz wrote: >> On 29.10.19 13:05, Vladimir Sementsov-Ogievskiy wrote: >>> 29.10.2019 14:55, Max Reitz wrote: On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 11:50, Max Reitz wrote: >> On

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Vladimir Sementsov-Ogievskiy
29.10.2019 15:11, Max Reitz wrote: > On 29.10.19 13:05, Vladimir Sementsov-Ogievskiy wrote: >> 29.10.2019 14:55, Max Reitz wrote: >>> On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: 29.10.2019 11:50, Max Reitz wrote: > On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: >> 28

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Max Reitz
On 29.10.19 13:05, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 14:55, Max Reitz wrote: >> On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: >>> 29.10.2019 11:50, Max Reitz wrote: On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: > 28.10.2019 14:04, Kevin Wolf wrote: >> A

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Vladimir Sementsov-Ogievskiy
29.10.2019 14:55, Max Reitz wrote: > On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: >> 29.10.2019 11:50, Max Reitz wrote: >>> On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: 28.10.2019 14:04, Kevin Wolf wrote: > Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: >>

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Max Reitz
On 29.10.19 12:48, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2019 11:50, Max Reitz wrote: >> On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: >>> 28.10.2019 14:04, Kevin Wolf wrote: Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: > On Fri, Oct 25, 2019 at 11:58:46AM +0200,

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Vladimir Sementsov-Ogievskiy
29.10.2019 11:50, Max Reitz wrote: > On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: >> 28.10.2019 14:04, Kevin Wolf wrote: >>> Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: > > [...] > > (3) Drop handle_alloc_sp

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-29 Thread Max Reitz
On 28.10.19 12:25, Vladimir Sementsov-Ogievskiy wrote: > 28.10.2019 14:04, Kevin Wolf wrote: >> Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: >>> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: [...] (3) Drop handle_alloc_space(), i.e. revert c8bb23cbdbe32f. To

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-28 Thread Vladimir Sementsov-Ogievskiy
28.10.2019 14:04, Kevin Wolf wrote: > Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: >> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: >>> As for how we can address the issue, I see three ways: >>> (1) The one presented in this series: On XFS with aio=native, we extend >>>

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-28 Thread Vladimir Sementsov-Ogievskiy
28.10.2019 13:10, Max Reitz wrote: > On 28.10.19 11:07, Vladimir Sementsov-Ogievskiy wrote: >> 28.10.2019 12:56, Max Reitz wrote: >>> On 28.10.19 10:30, Max Reitz wrote: On 28.10.19 10:24, Max Reitz wrote: > On 27.10.19 13:35, Stefan Hajnoczi wrote: >> On Fri, Oct 25, 2019 at 11:58:46A

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-28 Thread Kevin Wolf
Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben: > On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: > > As for how we can address the issue, I see three ways: > > (1) The one presented in this series: On XFS with aio=native, we extend > > tracked requests for post-EOF fallocate

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-28 Thread Max Reitz
On 28.10.19 11:07, Vladimir Sementsov-Ogievskiy wrote: > 28.10.2019 12:56, Max Reitz wrote: >> On 28.10.19 10:30, Max Reitz wrote: >>> On 28.10.19 10:24, Max Reitz wrote: On 27.10.19 13:35, Stefan Hajnoczi wrote: > On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: >> As for ho

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-28 Thread Vladimir Sementsov-Ogievskiy
28.10.2019 12:56, Max Reitz wrote: > On 28.10.19 10:30, Max Reitz wrote: >> On 28.10.19 10:24, Max Reitz wrote: >>> On 27.10.19 13:35, Stefan Hajnoczi wrote: On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: > As for how we can address the issue, I see three ways: > (1) The on

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-28 Thread Max Reitz
On 28.10.19 10:30, Max Reitz wrote: > On 28.10.19 10:24, Max Reitz wrote: >> On 27.10.19 13:35, Stefan Hajnoczi wrote: >>> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: As for how we can address the issue, I see three ways: (1) The one presented in this series: On XFS with ai

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-28 Thread Max Reitz
On 28.10.19 10:24, Max Reitz wrote: > On 27.10.19 13:35, Stefan Hajnoczi wrote: >> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: >>> As for how we can address the issue, I see three ways: >>> (1) The one presented in this series: On XFS with aio=native, we extend >>> tracked reques

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-28 Thread Max Reitz
On 27.10.19 13:35, Stefan Hajnoczi wrote: > On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: >> As for how we can address the issue, I see three ways: >> (1) The one presented in this series: On XFS with aio=native, we extend >> tracked requests for post-EOF fallocate() calls (i.e., w

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-28 Thread Max Reitz
On 26.10.19 19:52, Vladimir Sementsov-Ogievskiy wrote: > 26.10.2019 20:37, Nir Soffer wrote: >> On Fri, Oct 25, 2019 at 1:11 PM Max Reitz wrote: >>> >>> Hi, >>> >>> It seems to me that there is a bug in Linux’s XFS kernel driver, as >>> I’ve explained here: >>> >>> https://lists.nongnu.org/archive

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-27 Thread Stefan Hajnoczi
On Fri, Oct 25, 2019 at 02:36:49PM +, Vladimir Sementsov-Ogievskiy wrote: > 25.10.2019 17:19, Max Reitz wrote: > > On 25.10.19 15:56, Vladimir Sementsov-Ogievskiy wrote: > >> 25.10.2019 16:40, Vladimir Sementsov-Ogievskiy wrote: > >>> 25.10.2019 12:58, Max Reitz wrote: > Hi, > >

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-27 Thread Stefan Hajnoczi
On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote: > As for how we can address the issue, I see three ways: > (1) The one presented in this series: On XFS with aio=native, we extend > tracked requests for post-EOF fallocate() calls (i.e., write-zero > operations) to reach until infi

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-26 Thread Vladimir Sementsov-Ogievskiy
26.10.2019 20:37, Nir Soffer wrote: > On Fri, Oct 25, 2019 at 1:11 PM Max Reitz wrote: >> >> Hi, >> >> It seems to me that there is a bug in Linux’s XFS kernel driver, as >> I’ve explained here: >> >> https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg01429.html >> >> In combination with

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-26 Thread Nir Soffer
On Fri, Oct 25, 2019 at 1:11 PM Max Reitz wrote: > > Hi, > > It seems to me that there is a bug in Linux’s XFS kernel driver, as > I’ve explained here: > > https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg01429.html > > In combination with our commit c8bb23cbdbe32f, this may lead to gue

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191025095849.25283-1-mre...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Peter Maydell
On Fri, 25 Oct 2019 at 15:21, Max Reitz wrote: > > On 25.10.19 16:17, Peter Maydell wrote: > > On Fri, 25 Oct 2019 at 15:16, Max Reitz wrote: > >> I’ve created an RH BZ here: > >> > >> https://bugzilla.redhat.com/show_bug.cgi?id=1765547 > > > > Currently "You are not authorized to access bug #176

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Kevin Wolf
Am 25.10.2019 um 16:19 hat Max Reitz geschrieben: > On 25.10.19 15:56, Vladimir Sementsov-Ogievskiy wrote: > > 25.10.2019 16:40, Vladimir Sementsov-Ogievskiy wrote: > >> 25.10.2019 12:58, Max Reitz wrote: > >>> Hi, > >>> > >>> It seems to me that there is a bug in Linux’s XFS kernel driver, as > >>

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Vladimir Sementsov-Ogievskiy
25.10.2019 17:19, Max Reitz wrote: > On 25.10.19 15:56, Vladimir Sementsov-Ogievskiy wrote: >> 25.10.2019 16:40, Vladimir Sementsov-Ogievskiy wrote: >>> 25.10.2019 12:58, Max Reitz wrote: Hi, It seems to me that there is a bug in Linux’s XFS kernel driver, as I’ve explained here

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Max Reitz
On 25.10.19 16:17, Peter Maydell wrote: > On Fri, 25 Oct 2019 at 15:16, Max Reitz wrote: >> >> On 25.10.19 15:46, Peter Maydell wrote: >>> On Fri, 25 Oct 2019 at 11:09, Max Reitz wrote: Hi, It seems to me that there is a bug in Linux’s XFS kernel driver, as I’ve explained

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Max Reitz
On 25.10.19 15:56, Vladimir Sementsov-Ogievskiy wrote: > 25.10.2019 16:40, Vladimir Sementsov-Ogievskiy wrote: >> 25.10.2019 12:58, Max Reitz wrote: >>> Hi, >>> >>> It seems to me that there is a bug in Linux’s XFS kernel driver, as >>> I’ve explained here: >>> >>> https://lists.nongnu.org/archive/

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Max Reitz
On 25.10.19 15:46, Peter Maydell wrote: > On Fri, 25 Oct 2019 at 11:09, Max Reitz wrote: >> >> Hi, >> >> It seems to me that there is a bug in Linux’s XFS kernel driver, as >> I’ve explained here: >> >> https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg01429.html >> >> In combination wit

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Peter Maydell
On Fri, 25 Oct 2019 at 15:16, Max Reitz wrote: > > On 25.10.19 15:46, Peter Maydell wrote: > > On Fri, 25 Oct 2019 at 11:09, Max Reitz wrote: > >> > >> Hi, > >> > >> It seems to me that there is a bug in Linux’s XFS kernel driver, as > >> I’ve explained here: > >> > >> https://lists.nongnu.org/ar

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Vladimir Sementsov-Ogievskiy
25.10.2019 16:40, Vladimir Sementsov-Ogievskiy wrote: > 25.10.2019 12:58, Max Reitz wrote: >> Hi, >> >> It seems to me that there is a bug in Linux’s XFS kernel driver, as >> I’ve explained here: >> >> https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg01429.html >> >> In combination with

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Peter Maydell
On Fri, 25 Oct 2019 at 11:09, Max Reitz wrote: > > Hi, > > It seems to me that there is a bug in Linux’s XFS kernel driver, as > I’ve explained here: > > https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg01429.html > > In combination with our commit c8bb23cbdbe32f, this may lead to guest

Re: [RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Vladimir Sementsov-Ogievskiy
25.10.2019 12:58, Max Reitz wrote: > Hi, > > It seems to me that there is a bug in Linux’s XFS kernel driver, as > I’ve explained here: > > https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg01429.html > > In combination with our commit c8bb23cbdbe32f, this may lead to guest > data corr

[RFC 0/3] block/file-posix: Work around XFS bug

2019-10-25 Thread Max Reitz
Hi, It seems to me that there is a bug in Linux’s XFS kernel driver, as I’ve explained here: https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg01429.html In combination with our commit c8bb23cbdbe32f, this may lead to guest data corruption when using qcow2 images on XFS with aio=native