Re: [RFC] hw/net/vmxnet3: allow VMXNET3_MAX_MTU itself as a value

2022-08-25 Thread P J P
On Wednesday, 24 August, 2022, 04:46:21 pm IST, Fiona Ebner wrote: >Reported by one of our users running into the failing assert(): >https://forum.proxmox.com/threads/114011/#post-492916 > >- assert(VMXNET3_MIN_MTU <= s->mtu && s->mtu < VMXNET3_MAX_MTU); >+ assert(VMXNET3_MIN_MTU <= s->mtu && s->

Re: [RFC] hw/net/vmxnet3: allow VMXNET3_MAX_MTU itself as a value

2022-08-24 Thread Jason Wang
On Wed, Aug 24, 2022 at 7:17 PM Fiona Ebner wrote: > > Fixes: d05dcd94ae ("net: vmxnet3: validate configuration values during > activate (CVE-2021-20203)") > Signed-off-by: Fiona Ebner > --- > > I'm not familiar with this code, so really I'm asking: is the change > justified? Patch looks good,

[RFC] hw/net/vmxnet3: allow VMXNET3_MAX_MTU itself as a value

2022-08-24 Thread Fiona Ebner
Fixes: d05dcd94ae ("net: vmxnet3: validate configuration values during activate (CVE-2021-20203)") Signed-off-by: Fiona Ebner --- I'm not familiar with this code, so really I'm asking: is the change justified? I tested the change and it seems to work, but I only have some rough rationale for it