Re: [RFC] block/nbd: Move s->ioc on AioContext change

2022-02-01 Thread Vladimir Sementsov-Ogievskiy
01.02.2022 19:14, Hanna Reitz wrote: reconnect_delay_timer should exist only during IO request: it's created during request if we don't have a connection. And request will not finish until timer elapsed or connection established (timer should be removed in this case too). So, again, when attac

Re: [RFC] block/nbd: Move s->ioc on AioContext change

2022-02-01 Thread Hanna Reitz
On 01.02.22 12:40, Hanna Reitz wrote: On 01.02.22 12:18, Vladimir Sementsov-Ogievskiy wrote: 28.01.2022 18:51, Hanna Reitz wrote: s->ioc must always be attached to the NBD node's AioContext.  If that context changes, s->ioc must be attached to the new context. Buglink: https://bugzilla.redhat.

Re: [RFC] block/nbd: Move s->ioc on AioContext change

2022-02-01 Thread Vladimir Sementsov-Ogievskiy
01.02.2022 14:40, Hanna Reitz wrote: On 01.02.22 12:18, Vladimir Sementsov-Ogievskiy wrote: 28.01.2022 18:51, Hanna Reitz wrote: s->ioc must always be attached to the NBD node's AioContext.  If that context changes, s->ioc must be attached to the new context. Buglink: https://bugzilla.redhat.c

Re: [RFC] block/nbd: Move s->ioc on AioContext change

2022-02-01 Thread Vladimir Sementsov-Ogievskiy
28.01.2022 18:51, Hanna Reitz wrote: s->ioc must always be attached to the NBD node's AioContext. If that context changes, s->ioc must be attached to the new context. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1990835 Signed-off-by: Hanna Reitz --- This is an RFC because I believe th

Re: [RFC] block/nbd: Move s->ioc on AioContext change

2022-02-01 Thread Hanna Reitz
On 01.02.22 12:18, Vladimir Sementsov-Ogievskiy wrote: 28.01.2022 18:51, Hanna Reitz wrote: s->ioc must always be attached to the NBD node's AioContext.  If that context changes, s->ioc must be attached to the new context. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1990835 Signed-off-

Re: [RFC] block/nbd: Move s->ioc on AioContext change

2022-01-28 Thread Eric Blake
On Fri, Jan 28, 2022 at 04:51:30PM +0100, Hanna Reitz wrote: > s->ioc must always be attached to the NBD node's AioContext. If that > context changes, s->ioc must be attached to the new context. Eww. Good catch; and looks like it is not the first time where we've run into issues (a quick grep fo

[RFC] block/nbd: Move s->ioc on AioContext change

2022-01-28 Thread Hanna Reitz
s->ioc must always be attached to the NBD node's AioContext. If that context changes, s->ioc must be attached to the new context. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1990835 Signed-off-by: Hanna Reitz --- This is an RFC because I believe there are some other things in the NBD bl