Re: [RFC] accel: add cpu_reset

2021-03-23 Thread Philippe Mathieu-Daudé
On 3/22/21 2:54 PM, Claudio Fontana wrote: > On 3/22/21 2:42 PM, Philippe Mathieu-Daudé wrote: >> On 3/22/21 2:27 PM, Claudio Fontana wrote: >>> XXX >>> --- >>> accel/accel-common.c| 9 + >>> hw/core/cpu.c | 3 ++- >>> include/hw/core/accel-cpu.h | 2 ++ >>> include/q

Re: [RFC] accel: add cpu_reset

2021-03-23 Thread Paolo Bonzini
On 22/03/21 14:51, Claudio Fontana wrote: It is possible to include calls from one sourceset to another (including from common to specific) as long as the conditions ensure that the symbol is defined. I guess this last sentence is the more tricky for me to get: "as long as the conditions ensu

Re: [RFC] accel: add cpu_reset

2021-03-22 Thread Claudio Fontana
On 3/22/21 2:42 PM, Philippe Mathieu-Daudé wrote: > On 3/22/21 2:27 PM, Claudio Fontana wrote: >> XXX >> --- >> accel/accel-common.c| 9 + >> hw/core/cpu.c | 3 ++- >> include/hw/core/accel-cpu.h | 2 ++ >> include/qemu/accel.h| 6 ++ >> target/i386/cpu.c

Re: [RFC] accel: add cpu_reset

2021-03-22 Thread Paolo Bonzini
On 22/03/21 14:35, Claudio Fontana wrote: On 3/22/21 2:31 PM, Paolo Bonzini wrote: On 22/03/21 14:27, Claudio Fontana wrote: This surprisingly works without moving cpu_reset() to a specific_ss module, even though accel-common.c is specific_ss, hw/core/cpu.c is common_ss. How come the call to ac

Re: [RFC] accel: add cpu_reset

2021-03-22 Thread Philippe Mathieu-Daudé
On 3/22/21 2:27 PM, Claudio Fontana wrote: > XXX > --- > accel/accel-common.c| 9 + > hw/core/cpu.c | 3 ++- > include/hw/core/accel-cpu.h | 2 ++ > include/qemu/accel.h| 6 ++ > target/i386/cpu.c | 4 > target/i386/kvm/kvm-cpu.c | 6 +

Re: [RFC] accel: add cpu_reset

2021-03-22 Thread Claudio Fontana
On 3/22/21 2:45 PM, Paolo Bonzini wrote: > On 22/03/21 14:35, Claudio Fontana wrote: >> On 3/22/21 2:31 PM, Paolo Bonzini wrote: >>> On 22/03/21 14:27, Claudio Fontana wrote: This surprisingly works without moving cpu_reset() to a specific_ss module, even though accel-common.c is specific

Re: [RFC] accel: add cpu_reset

2021-03-22 Thread Claudio Fontana
On 3/22/21 2:31 PM, Paolo Bonzini wrote: > On 22/03/21 14:27, Claudio Fontana wrote: >> This surprisingly works without moving cpu_reset() to a specific_ss >> module, even though accel-common.c is specific_ss, hw/core/cpu.c is >> common_ss. How come the call to accel_reset_cpu works? > > I don't

Re: [RFC] accel: add cpu_reset

2021-03-22 Thread Paolo Bonzini
On 22/03/21 14:27, Claudio Fontana wrote: This surprisingly works without moving cpu_reset() to a specific_ss module, even though accel-common.c is specific_ss, hw/core/cpu.c is common_ss. How come the call to accel_reset_cpu works? I don't understand the question. Why wouldn't it work? :) P

[RFC v28 23/23] XXX RFC accel: add cpu_reset

2021-03-22 Thread Claudio Fontana
XXX this surprisingly works without moving cpu_reset() to a specific_ss module, even though accel-common.c is specific_ss, hw/core/cpu.c is common_ss. How come the call to accel_reset_cpu works, and passes all tests? Signed-off-by: Claudio Fontana --- include/hw/core/accel-cpu.h | 2 ++ inclu

[RFC] accel: add cpu_reset

2021-03-22 Thread Claudio Fontana
XXX --- accel/accel-common.c| 9 + hw/core/cpu.c | 3 ++- include/hw/core/accel-cpu.h | 2 ++ include/qemu/accel.h| 6 ++ target/i386/cpu.c | 4 target/i386/kvm/kvm-cpu.c | 6 ++ 6 files changed, 25 insertions(+), 5 deletions(-) This

[RFC] accel: add cpu_reset

2021-03-19 Thread Claudio Fontana
XXX --- accel/accel-common.c| 9 + hw/core/cpu.c | 3 ++- include/hw/core/accel-cpu.h | 2 ++ include/qemu/accel.h| 6 ++ target/i386/cpu.c | 4 target/i386/kvm/kvm-cpu.c | 6 ++ 6 files changed, 25 insertions(+), 5 deletions(-) This