Re: [Qemu-devel] virtio_cleanup() missing in virtio-{blk, balloon, 9p}-pci

2010-10-12 Thread Markus Armbruster
"M. Mohan Kumar" writes: >> Pattern: >> >> FOO's PCIDeviceInfo method exit is virtio_FOO_exit_pci(), which calls >> virtio_FOO_exit() and virtio_exit_pci(). >> >> virtio_{net,serial}_exit() call virtio_cleanup(). >> >> virtio_blk_exit() doesn't. Why? >> >> virtio-balloon-pci uses virtio_exit

Re: [Qemu-devel] virtio_cleanup() missing in virtio-{blk, balloon, 9p}-pci

2010-10-12 Thread M. Mohan Kumar
> Pattern: > > FOO's PCIDeviceInfo method exit is virtio_FOO_exit_pci(), which calls > virtio_FOO_exit() and virtio_exit_pci(). > > virtio_{net,serial}_exit() call virtio_cleanup(). > > virtio_blk_exit() doesn't. Why? > > virtio-balloon-pci uses virtio_exit_pci() as exit method. No > virtio_c

[Qemu-devel] virtio_cleanup() missing in virtio-{blk, balloon, 9p}-pci

2010-10-11 Thread Markus Armbruster
Pattern: FOO's PCIDeviceInfo method exit is virtio_FOO_exit_pci(), which calls virtio_FOO_exit() and virtio_exit_pci(). virtio_{net,serial}_exit() call virtio_cleanup(). virtio_blk_exit() doesn't. Why? virtio-balloon-pci uses virtio_exit_pci() as exit method. No virtio_cleanup()? virtio-9p-p