Re: [Qemu-devel] virtio 1 issues

2015-08-10 Thread Cornelia Huck
On Mon, 10 Aug 2015 14:22:07 +0800 Jason Wang wrote: > > > On 08/07/2015 06:49 PM, Cornelia Huck wrote: > > On Fri, 07 Aug 2015 13:07:35 +0800 > > Jason Wang wrote: > > > >>> 2. ring resizing is broken - it actually has a comment: > >>> /* TODO: need a way to put num back on reset. */

Re: [Qemu-devel] virtio 1 issues

2015-08-09 Thread Jason Wang
On 08/07/2015 06:49 PM, Cornelia Huck wrote: > On Fri, 07 Aug 2015 13:07:35 +0800 > Jason Wang wrote: > >>> 2. ring resizing is broken - it actually has a comment: >>> /* TODO: need a way to put num back on reset. */ >>> guest that runs out of memory might down-size the ring. >>> Afterwa

Re: [Qemu-devel] virtio 1 issues

2015-08-07 Thread Cornelia Huck
On Fri, 07 Aug 2015 13:07:35 +0800 Jason Wang wrote: > > 2. ring resizing is broken - it actually has a comment: > > /* TODO: need a way to put num back on reset. */ > > guest that runs out of memory might down-size the ring. > > Afterwards, ring size won't come back up after reset - not

Re: [Qemu-devel] virtio 1 issues

2015-08-06 Thread Jason Wang
On 08/07/2015 06:31 AM, Michael S. Tsirkin wrote: > Going over the code, I found a couple of issues. > Recording them here since I won't be able to work > on them until after the forum. > > > 1. I realized we don't save/restore > serialize the following fields in virtio pci: > > uint32_t dfse

[Qemu-devel] virtio 1 issues

2015-08-06 Thread Michael S. Tsirkin
Going over the code, I found a couple of issues. Recording them here since I won't be able to work on them until after the forum. 1. I realized we don't save/restore serialize the following fields in virtio pci: uint32_t dfselect; uint32_t gfselect; uint32_t guest_features[2]; st