Re: [Qemu-devel] virtio-scsi spec, first public draft

2011-05-06 Thread Paolo Bonzini
On 05/06/2011 02:31 PM, Stefan Hajnoczi wrote: Okay, this explains how you plan to handle targets appearing - you want to set a maximum number of targets. I was wondering how we would add virtqueues dynamically (and why the control vqs are placed last at n,n+1 instead of 0,1). You don't, it's

Re: [Qemu-devel] virtio-scsi spec, first public draft

2011-05-06 Thread Stefan Hajnoczi
On Thu, May 5, 2011 at 3:50 PM, Paolo Bonzini wrote: > On 05/05/2011 04:29 PM, Hannes Reinecke wrote: >>> >>> I chose 1 requestq per target so that, with MSI-X support, each >>> target can be associated to one MSI-X vector. >>> >>> If you want a large number of units, you can subdivide targets int

Re: [Qemu-devel] virtio-scsi spec, first public draft

2011-05-05 Thread Paolo Bonzini
On 05/05/2011 04:29 PM, Hannes Reinecke wrote: I chose 1 requestq per target so that, with MSI-X support, each target can be associated to one MSI-X vector. If you want a large number of units, you can subdivide targets into logical units, or use multiple adapters if you prefer. We can have 20-o

Re: [Qemu-devel] virtio-scsi spec, first public draft

2011-05-05 Thread Hannes Reinecke
Hi all, On 05/05/2011 02:49 PM, Paolo Bonzini wrote: Virtqueues 0..n-1:one requestq per target n:control transmitq n+1:control receiveq 1 requestq per target makes it harder to support large numbers or dynamic targets. I chose 1 requestq per target so that, with MSI-X support, each target ca

Re: [Qemu-devel] virtio-scsi spec, first public draft

2011-05-05 Thread Paolo Bonzini
On 05/05/2011 02:50 PM, Christoph Hellwig wrote: Please don't repeat the barrier mistake done in the Xen and virtio-blk/lguest protocols. It really doesn't make sense to put this kind of strict odering in. If we really want ordering let's do it using SCSI ordered tags at least to use a standard

Re: [Qemu-devel] virtio-scsi spec, first public draft

2011-05-05 Thread Christoph Hellwig
> #define VIRTIO_SCSI_T_BARRIER 0x8000 > > The type identifies the remaining fields. The value > VIRTIO_SCSI_T_BARRIER can be ORed in the type as well. This bit > indicates that this request acts as a barrier and that all preceding > requests must be complete befo

Re: [Qemu-devel] virtio-scsi spec, first public draft

2011-05-05 Thread Paolo Bonzini
Virtqueues 0..n-1:one requestq per target n:control transmitq n+1:control receiveq 1 requestq per target makes it harder to support large numbers or dynamic targets. I chose 1 requestq per target so that, with MSI-X support, each target can be associated to one MSI-X vector.

Re: [Qemu-devel] virtio-scsi spec, first public draft

2011-05-05 Thread Stefan Hajnoczi
On Thu, May 05, 2011 at 12:28:31AM +0200, Paolo Bonzini wrote: > Virtio SCSI Controller Device Spec > == > > The virtio controller device groups together one or more simple virtual > devices (ie. disk), and allows communicating to these devices using the > SCSI prot

[Qemu-devel] virtio-scsi spec, first public draft

2011-05-04 Thread Paolo Bonzini
Here it is at last... It might be overengineered, I'm waiting for the SCSI experts to tell me about that. :) Paolo Virtio SCSI Controller Device Spec == The virtio controller device groups together one or more simple virtual devices (ie. disk), and allows commu