Re: [Qemu-devel] tcg conditional set/move, round 3

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 08:19:32AM -0800, Richard Henderson wrote: > On 12/19/2009 05:03 AM, Aurelien Jarno wrote: > >- For the movcond instruction, is there a real use for vtrue and vfalse > > values? Most CPU actually implement a version with one value. > > Implementing it with two values mov

Re: [Qemu-devel] tcg conditional set/move, round 3

2009-12-19 Thread Richard Henderson
On 12/19/2009 05:03 AM, Aurelien Jarno wrote: - For the movcond instruction, is there a real use for vtrue and vfalse values? Most CPU actually implement a version with one value. Implementing it with two values moves complexity within the arch specific tcg code. The reason I added bot

Re: [Qemu-devel] tcg conditional set/move, round 3

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 02:03:46PM +0100, Aurelien Jarno wrote: > On Fri, Dec 18, 2009 at 01:38:24PM -0800, Richard Henderson wrote: > > On 12/18/2009 03:37 AM, Laurent Desnogues wrote: > >>> tcg: Generic support for conditional set and conditional move. > >> > >> Needs cosmetics changes. > > > >

Re: [Qemu-devel] tcg conditional set/move, round 3

2009-12-19 Thread Aurelien Jarno
On Fri, Dec 18, 2009 at 01:38:24PM -0800, Richard Henderson wrote: > On 12/18/2009 03:37 AM, Laurent Desnogues wrote: >>> tcg: Generic support for conditional set and conditional move. >> >> Needs cosmetics changes. > > Fixed, attachment 1. > >>> tcg-x86_64: Implement setcond and movcond. >> >>

Re: [Qemu-devel] tcg conditional set/move, round 3

2009-12-19 Thread Andreas Färber
Hello, Am 18.12.2009 um 22:38 schrieb Richard Henderson: jmps.txt> Please send patches inline (and one patch per mail, like your original series), then a) you get more review comments and b) we can apply the patches with git-am (including your description) for testing. You can use git-send

[Qemu-devel] tcg conditional set/move, round 3

2009-12-18 Thread Richard Henderson
On 12/18/2009 03:37 AM, Laurent Desnogues wrote: tcg: Generic support for conditional set and conditional move. Needs cosmetics changes. Fixed, attachment 1. tcg-x86_64: Implement setcond and movcond. Some cosmetics and comments, but overall good. Fixed, attachment 2. tcg-i386: