Re: [Qemu-devel] regression: sata cdrom boot broken

2018-06-21 Thread Paolo Bonzini
On 20/06/2018 20:15, Thomas Huth wrote: > On 20.06.2018 13:07, Gerd Hoffmann wrote: >> Hi, >> >> $subject says all. Noticed while testing the upcoming seabios update. >> Reproducer: >> >> qemu-system-x86_64 -M q35 -m 4G -cdrom >> Fedora-Workstation-Live-x86_64-28-1.1.iso > > Once this has be

Re: [Qemu-devel] regression: sata cdrom boot broken

2018-06-21 Thread Paolo Bonzini
On 20/06/2018 22:28, John Snow wrote: > > ...Oh. So the PIO Setup FIS ... gets generated before the data is sent, > but we don't copy it to the HBA memory buffers and notify the client > until afterwards, but this is per-DRQ, I think, and not per-IDE command. No, the copy happens before: "When a

Re: [Qemu-devel] regression: sata cdrom boot broken

2018-06-20 Thread John Snow
On 06/20/2018 08:18 AM, Paolo Bonzini wrote: > On 20/06/2018 13:07, Gerd Hoffmann wrote: >> Hi, >> >> $subject says all. Noticed while testing the upcoming seabios update. >> Reproducer: >> >> qemu-system-x86_64 -M q35 -m 4G -cdrom >> Fedora-Workstation-Live-x86_64-28-1.1.iso >> >> bisecte

Re: [Qemu-devel] regression: sata cdrom boot broken

2018-06-20 Thread Thomas Huth
On 20.06.2018 13:07, Gerd Hoffmann wrote: > Hi, > > $subject says all. Noticed while testing the upcoming seabios update. > Reproducer: > > qemu-system-x86_64 -M q35 -m 4G -cdrom > Fedora-Workstation-Live-x86_64-28-1.1.iso Once this has been fixed, please add a regression test to tests/cdr

Re: [Qemu-devel] regression: sata cdrom boot broken

2018-06-20 Thread Paolo Bonzini
On 20/06/2018 13:07, Gerd Hoffmann wrote: > Hi, > > $subject says all. Noticed while testing the upcoming seabios update. > Reproducer: > > qemu-system-x86_64 -M q35 -m 4G -cdrom > Fedora-Workstation-Live-x86_64-28-1.1.iso > > bisected to: > > commit 956556e131e35f387ac482ad7b41151576fe

[Qemu-devel] regression: sata cdrom boot broken

2018-06-20 Thread Gerd Hoffmann
Hi, $subject says all. Noticed while testing the upcoming seabios update. Reproducer: qemu-system-x86_64 -M q35 -m 4G -cdrom Fedora-Workstation-Live-x86_64-28-1.1.iso bisected to: commit 956556e131e35f387ac482ad7b41151576fef057 Author: John Snow Date: Wed Jun 6 15:09:50 2018 -040