Re: [Qemu-devel] libiscsi task cancellation

2018-02-14 Thread Felipe Franciosi
> On 8 Feb 2018, at 15:08, Stefan Hajnoczi wrote: > > On Thu, Feb 8, 2018 at 2:14 PM, Paolo Bonzini wrote: >> On 08/02/2018 15:08, Stefan Hajnoczi wrote: >>> Now on to libiscsi: >>> >>> The iscsi_task_mgmt_async() API documentation says: >>> >>> * abort_task will also cancel the scsi task. T

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Felipe Franciosi
> On 8 Feb 2018, at 14:58, Hannes Reinecke wrote: > > On 02/08/2018 03:14 PM, Paolo Bonzini wrote: >> On 08/02/2018 15:08, Stefan Hajnoczi wrote: >>> Now on to libiscsi: >>> >>> The iscsi_task_mgmt_async() API documentation says: >>> >>> * abort_task will also cancel the scsi task. The callba

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Stefan Hajnoczi
On Thu, Feb 8, 2018 at 3:08 PM, Stefan Hajnoczi wrote: > On Thu, Feb 8, 2018 at 2:14 PM, Paolo Bonzini wrote: >> On 08/02/2018 15:08, Stefan Hajnoczi wrote: > I think users *can* work around the iscsi_task_mgmt_async() issue as follows: > > If the command callback has not been invoked yet when th

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Stefan Hajnoczi
On Thu, Feb 8, 2018 at 2:58 PM, Hannes Reinecke wrote: > On 02/08/2018 03:14 PM, Paolo Bonzini wrote: >> On 08/02/2018 15:08, Stefan Hajnoczi wrote: >>> Now on to libiscsi: >>> >>> The iscsi_task_mgmt_async() API documentation says: >>> >>> * abort_task will also cancel the scsi task. The callba

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Stefan Hajnoczi
On Thu, Feb 8, 2018 at 2:14 PM, Paolo Bonzini wrote: > On 08/02/2018 15:08, Stefan Hajnoczi wrote: >> Now on to libiscsi: >> >> The iscsi_task_mgmt_async() API documentation says: >> >> * abort_task will also cancel the scsi task. The callback for the >> scsi task will be invoked with >> *

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Hannes Reinecke
On 02/08/2018 03:14 PM, Paolo Bonzini wrote: > On 08/02/2018 15:08, Stefan Hajnoczi wrote: >> Now on to libiscsi: >> >> The iscsi_task_mgmt_async() API documentation says: >> >> * abort_task will also cancel the scsi task. The callback for the >> scsi task will be invoked with >> *S

[Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Stefan Hajnoczi
SAM-5, 5.6 Aborting commands says: A command is aborted when a SCSI device condition (see 6.3), command, or task management function causes termination of the command prior to its completion by the device server. After a command is aborted and TASK ABORTED status, if any, is returned, the

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Paolo Bonzini
On 08/02/2018 15:08, Stefan Hajnoczi wrote: > Now on to libiscsi: > > The iscsi_task_mgmt_async() API documentation says: > > * abort_task will also cancel the scsi task. The callback for the > scsi task will be invoked with > *SCSI_STATUS_CANCELLED > > I see that the ABORT TASK