Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > On Tue, Nov 24, 2015 at 2:50 PM, Markus Armbruster wrote: > >> Facts: >> >> * We have a half-initialized state that is visible to the guest. >> >> * To detect the doorbell, you have to wait for the device to exit this >> state. >> >> * Recognizing this state

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi On Tue, Nov 24, 2015 at 2:50 PM, Markus Armbruster wrote: > Facts: > > * We have a half-initialized state that is visible to the guest. > > * To detect the doorbell, you have to wait for the device to exit this > state. > > * Recognizing this state is cumbersome unless you already know you

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > On Tue, Nov 24, 2015 at 10:56 AM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Hi >>> >>> - Original Message - On 11/23/2015 07:46 AM, Markus Armbruster wrote: >>> If it's not broken, please explain to me how the guest sh

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi On Tue, Nov 24, 2015 at 10:56 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Hi >> >> - Original Message - >>> On 11/23/2015 07:46 AM, Markus Armbruster wrote: >>> >>> >>> If it's not broken, please explain to me how the guest should find out >>> >>> whether its ivshmem

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > - Original Message - >> On 11/23/2015 07:46 AM, Markus Armbruster wrote: >> >> >>> If it's not broken, please explain to me how the guest should find out >> >>> whether its ivshmem device sports a doorbell. >> >> >> >> If you have received ID, you shoul

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Andrew James writes: > On 11/20/2015 01:18 PM, Marc-André Lureau wrote: >> Hi >> >> - Original Message - > Hash ivshmem been used in anger? If yes, how? >>> >>> Still the question to answer. >> >> I don't expect users to read this ML everyday (anybody >> actually). Personally, I ha

Re: [Qemu-devel] ivshmem property size should be a size, not a string

On 11/20/2015 01:18 PM, Marc-André Lureau wrote: > Hi > > - Original Message - Hash ivshmem been used in anger? If yes, how? >> >> Still the question to answer. > > I don't expect users to read this ML everyday (anybody actually). Personally, > I have no clue how widespread ivshmem

Re: [Qemu-devel] ivshmem property size should be a size, not a string

>>> On 11/20/2015 at 09:07 AM, Markus Armbruster wrote: > Everybody's favourite device model has "size" property. It's declared > as *string* > > DEFINE_PROP_STRING("size", IVShmemState, sizearg), > > which gets converted to a size manually in the realize method: > > } else if (s->siz

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > On 11/23/2015 07:46 AM, Markus Armbruster wrote: > > >>> If it's not broken, please explain to me how the guest should find out > >>> whether its ivshmem device sports a doorbell. > >> > >> If you have received ID, you should be good to use the doorbell. > > > >

Re: [Qemu-devel] ivshmem property size should be a size, not a string

On 11/23/2015 07:46 AM, Markus Armbruster wrote: >>> If it's not broken, please explain to me how the guest should find out >>> whether its ivshmem device sports a doorbell. >> >> If you have received ID, you should be good to use the doorbell. > > That's not a complete answer, so let me try a di

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Markus Armbruster writes: > Marc-André Lureau writes: [...] >>> * shm appears to be the same as memdev, just less flexible. Why does it >>> exist? >> >> It was there before. > > Not only is memdev more flexible, it also provides the clean split > between frontend and backend we generally want

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > - Original Message - >> Marc-André Lureau writes: >> >> > Hi >> > >> > - Original Message - >> >> > >> >> > You can't migrate the peers. >> >> >> >> Then explain the case N'=0 to me: how can you migrate the master so that >> >> it's connected to a se

Re: [Qemu-devel] ivshmem property size should be a size, not a string

- Original Message - > Marc-André Lureau writes: > > > Hi > > > > - Original Message - > >> > > >> > You can't migrate the peers. > >> > >> Then explain the case N'=0 to me: how can you migrate the master so that > >> it's connected to a server afterwards? > > > > Dest qemu: -i

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > - Original Message - >> > >> > You can't migrate the peers. >> >> Then explain the case N'=0 to me: how can you migrate the master so that >> it's connected to a server afterwards? > > Dest qemu: -incoming.. -chardev socket,path=dest-server > > That is

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > > > > You can't migrate the peers. > > Then explain the case N'=0 to me: how can you migrate the master so that > it's connected to a server afterwards? Dest qemu: -incoming.. -chardev socket,path=dest-server That is, start your destination qemu with a destina

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > - Original Message - >> > "role" was designed to only migrate the master. Ability to migrate a pool >> > of >> > peer would be a significant new feature. I am not aware of such request. >> >> I see. But how is this supposed to work? >> >> Before migra

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > > "role" was designed to only migrate the master. Ability to migrate a pool > > of > > peer would be a significant new feature. I am not aware of such request. > > I see. But how is this supposed to work? > > Before migration: one master and N peers connected t

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > - Original Message - >> >> >> qemu-doc documents role only with chardev. The code doesn't care. >> > >> > yeah, role is only really useful with a server. Another missing warning. >> >> I think it makes sense only when we can migrate the shared memory >

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > > >> qemu-doc documents role only with chardev. The code doesn't care. > > > > yeah, role is only really useful with a server. Another missing warning. > > I think it makes sense only when we can migrate the shared memory > contents out-of-band. Vaguely similar

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > - Original Message - >> >> Hash ivshmem been used in anger? If yes, how? >> >> Still the question to answer. > > I don't expect users to read this ML everyday (anybody > actually). Personally, I have no clue how widespread ivshmem usage is. > >> Beside

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > >> Hash ivshmem been used in anger? If yes, how? > > Still the question to answer. I don't expect users to read this ML everyday (anybody actually). Personally, I have no clue how widespread ivshmem usage is. > Besides the usual PCI properties, we have: > >

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > - Original Message - >> Eric Blake writes: >> >> > On 11/20/2015 09:23 AM, Marc-André Lureau wrote: >> >> Hi >> >> >> >> - Original Message - >> >>> Everybody's favourite device model has "size" property. It's declared >> >>> as *string* >> >>> >> >

Re: [Qemu-devel] ivshmem property size should be a size, not a string

- Original Message - > Eric Blake writes: > > > On 11/20/2015 09:23 AM, Marc-André Lureau wrote: > >> Hi > >> > >> - Original Message - > >>> Everybody's favourite device model has "size" property. It's declared > >>> as *string* > >>> > >>> DEFINE_PROP_STRING("size", IVSh

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Eric Blake writes: > On 11/20/2015 09:23 AM, Marc-André Lureau wrote: >> Hi >> >> - Original Message - >>> Everybody's favourite device model has "size" property. It's declared >>> as *string* >>> >>> DEFINE_PROP_STRING("size", IVShmemState, sizearg), >>> >>> >>> * In QMP, the size

Re: [Qemu-devel] ivshmem property size should be a size, not a string

On 11/20/2015 09:23 AM, Marc-André Lureau wrote: > Hi > > - Original Message - >> Everybody's favourite device model has "size" property. It's declared >> as *string* >> >> DEFINE_PROP_STRING("size", IVShmemState, sizearg), >> >> >> * In QMP, the size must be given as JSON string inst

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > Everybody's favourite device model has "size" property. It's declared > as *string* > > DEFINE_PROP_STRING("size", IVShmemState, sizearg), > > which gets converted to a size manually in the realize method: > > } else if (s->sizearg == NULL) { >

[Qemu-devel] ivshmem property size should be a size, not a string

Everybody's favourite device model has "size" property. It's declared as *string* DEFINE_PROP_STRING("size", IVShmemState, sizearg), which gets converted to a size manually in the realize method: } else if (s->sizearg == NULL) { s->ivshmem_size = 4 << 20; /* 4 MB default */