Re: [Qemu-devel] directory hierarchy

2012-09-24 Thread Avi Kivity
On 09/23/2012 06:07 PM, Blue Swirl wrote: > On Sun, Sep 23, 2012 at 8:25 AM, Avi Kivity wrote: >> On 09/22/2012 04:15 PM, Blue Swirl wrote: >>> > >>> >> This could have nice cleanup effects though and for example enable >>> >> generic 'info vmtree' to discover VA->PA mappings for any target >>> >>

Re: [Qemu-devel] directory hierarchy

2012-09-23 Thread Blue Swirl
On Sun, Sep 23, 2012 at 8:25 AM, Avi Kivity wrote: > On 09/22/2012 04:15 PM, Blue Swirl wrote: >> > >> >> This could have nice cleanup effects though and for example enable >> >> generic 'info vmtree' to discover VA->PA mappings for any target >> >> instead of current MMU table walkers. >> > >> >

Re: [Qemu-devel] directory hierarchy

2012-09-23 Thread Avi Kivity
On 09/22/2012 04:15 PM, Blue Swirl wrote: > > > >> This could have nice cleanup effects though and for example enable > >> generic 'info vmtree' to discover VA->PA mappings for any target > >> instead of current MMU table walkers. > > > > How? That's in a hardware defined format that's completely

Re: [Qemu-devel] directory hierarchy

2012-09-22 Thread Blue Swirl
On Thu, Sep 20, 2012 at 11:31 AM, Avi Kivity wrote: > On 09/19/2012 10:57 PM, Blue Swirl wrote: >> On Wed, Sep 19, 2012 at 12:54 PM, Avi Kivity wrote: >>> On 09/14/2012 10:51 PM, Blue Swirl wrote: > > exec: These files need cleanup so that TCG code gets into tcg/. Maybe also >>>

Re: [Qemu-devel] directory hierarchy

2012-09-20 Thread Avi Kivity
On 09/19/2012 10:57 PM, Blue Swirl wrote: > On Wed, Sep 19, 2012 at 12:54 PM, Avi Kivity wrote: >> On 09/14/2012 10:51 PM, Blue Swirl wrote: exec: >>> >>> These files need cleanup so that TCG code gets into tcg/. Maybe also >>> TB and CPUTLB handling. >> >> Some of that could be done by

Re: [Qemu-devel] directory hierarchy

2012-09-19 Thread Blue Swirl
On Wed, Sep 19, 2012 at 12:54 PM, Avi Kivity wrote: > On 09/14/2012 10:51 PM, Blue Swirl wrote: >>> >>> exec: >> >> These files need cleanup so that TCG code gets into tcg/. Maybe also >> TB and CPUTLB handling. > > Some of that could be done by adding a separate MemoryListener for tcg. But the T

Re: [Qemu-devel] directory hierarchy

2012-09-19 Thread Avi Kivity
On 09/14/2012 10:51 PM, Blue Swirl wrote: >> >> exec: > > These files need cleanup so that TCG code gets into tcg/. Maybe also > TB and CPUTLB handling. Some of that could be done by adding a separate MemoryListener for tcg. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] directory hierarchy

2012-09-17 Thread Anthony Liguori
Paolo Bonzini writes: > Il 16/09/2012 16:44, Anthony Liguori ha scritto: >> Thanks for doing this! I'm of the opinion that something is better than >> nothing here so I'll resist the urge to argue why blue is the best color >> for the shed. >> >> But one concern I have: this will be a big sourc

Re: [Qemu-devel] directory hierarchy

2012-09-17 Thread Paolo Bonzini
Il 16/09/2012 16:44, Anthony Liguori ha scritto: > Thanks for doing this! I'm of the opinion that something is better than > nothing here so I'll resist the urge to argue why blue is the best color > for the shed. > > But one concern I have: this will be a big source of rebasing. Perhaps > we ca

Re: [Qemu-devel] directory hierarchy

2012-09-17 Thread Paolo Bonzini
Il 16/09/2012 16:40, Anthony Liguori ha scritto: > It's good to put includes in a single direction such that you can do > -Iinclude and then: > > #include "qemu/foo.h" > > Which is better than: > > #include "foo.h" > > Because the later can create confusion/conflict with system headers > wherea

Re: [Qemu-devel] directory hierarchy

2012-09-16 Thread Anthony Liguori
Paolo Bonzini writes: > Hi all, > > here is a proposal for moving around 150 C files currently in the > toplevel directory to separate, well-delimited subdirectories. Header > files would be moved for now in include/, preparing for subsequent > reorganization of headers. > > Usually the files wo

Re: [Qemu-devel] directory hierarchy

2012-09-16 Thread Anthony Liguori
Paolo Bonzini writes: > Il 14/09/2012 15:36, Peter Maydell ha scritto: >> On 14 September 2012 14:17, Paolo Bonzini wrote: >>> here is a proposal for moving around 150 C files currently in the >>> toplevel directory to separate, well-delimited subdirectories. >> >> No general objection (though

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 21:51, Blue Swirl ha scritto: > On Fri, Sep 14, 2012 at 1:17 PM, Paolo Bonzini wrote: >> Hi all, >> >> here is a proposal for moving around 150 C files currently in the >> toplevel directory to separate, well-delimited subdirectories. Header >> files would be moved for now in includ

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Blue Swirl
On Fri, Sep 14, 2012 at 1:17 PM, Paolo Bonzini wrote: > Hi all, > > here is a proposal for moving around 150 C files currently in the > toplevel directory to separate, well-delimited subdirectories. Header > files would be moved for now in include/, preparing for subsequent > reorganization of he

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 18:09, Kevin Wolf ha scritto: > Cleaning up the main directory is probably a good idea. However, we > should be aware that renaming comes with a cost: Some git commands on a > single file need additional options (git log --follow) to work well > across renames, for others you need to

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 16:37, Stefan Weil ha scritto: > Here are some more ideas: > > * Move the target-xxx directories (currently 15) to target/xxx. Yes, of course. > * Add host/xxx for host specific files (xxx = posix, wxx). > Here the currently used win32 might be replaced by either > wxx or by wi

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Kevin Wolf
Am 14.09.2012 15:17, schrieb Paolo Bonzini: > Hi all, > > here is a proposal for moving around 150 C files currently in the > toplevel directory to separate, well-delimited subdirectories. Header > files would be moved for now in include/, preparing for subsequent > reorganization of headers. >

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Stefan Weil
Am 14.09.2012 15:17, schrieb Paolo Bonzini: Hi all, here is a proposal for moving around 150 C files currently in the toplevel directory to separate, well-delimited subdirectories. Header files would be moved for now in include/, preparing for subsequent reorganization of headers. Usually the

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 15:44, Luiz Capitulino ha scritto: >> > qapi: >> > error.c > error.c isn't tied to a subsystem, it's really "qemu wide". If it > must reside in dir (ie. it can't be in the top dir), then I'd > suggest to put it in qmp. It's either qapi/ or util/. I'd rather avoid util/ as a dumping

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Peter Maydell
On 14 September 2012 14:55, Paolo Bonzini wrote: > Il 14/09/2012 15:48, Peter Maydell ha scritto: >> ...oh, and it would be good to be sure we've fixed all the problems >> with dependencies that tend to cause 'make' to fail to DTRT going >> backwards and forwards across a file-move commit, before

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 15:47, Daniel P. Berrange ha scritto: > On Fri, Sep 14, 2012 at 03:17:52PM +0200, Paolo Bonzini wrote: >> Hi all, >> >> here is a proposal for moving around 150 C files currently in the >> toplevel directory to separate, well-delimited subdirectories. Header >> files would be moved f

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 15:48, Peter Maydell ha scritto: >> > here is a proposal for moving around 150 C files currently in the >> > toplevel directory to separate, well-delimited subdirectories. > ...oh, and it would be good to be sure we've fixed all the problems > with dependencies that tend to cause 'mak

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Paolo Bonzini
Il 14/09/2012 15:36, Peter Maydell ha scritto: > On 14 September 2012 14:17, Paolo Bonzini wrote: >> here is a proposal for moving around 150 C files currently in the >> toplevel directory to separate, well-delimited subdirectories. > > No general objection (though some specific comments below).

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Peter Maydell
On 14 September 2012 14:17, Paolo Bonzini wrote: > here is a proposal for moving around 150 C files currently in the > toplevel directory to separate, well-delimited subdirectories. ...oh, and it would be good to be sure we've fixed all the problems with dependencies that tend to cause 'make' to

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 03:17:52PM +0200, Paolo Bonzini wrote: > Hi all, > > here is a proposal for moving around 150 C files currently in the > toplevel directory to separate, well-delimited subdirectories. Header > files would be moved for now in include/, preparing for subsequent > reorganizat

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Luiz Capitulino
On Fri, 14 Sep 2012 15:17:52 +0200 Paolo Bonzini wrote: > Hi all, > > here is a proposal for moving around 150 C files currently in the > toplevel directory to separate, well-delimited subdirectories. Header > files would be moved for now in include/, preparing for subsequent > reorganization o

Re: [Qemu-devel] directory hierarchy

2012-09-14 Thread Peter Maydell
On 14 September 2012 14:17, Paolo Bonzini wrote: > here is a proposal for moving around 150 C files currently in the > toplevel directory to separate, well-delimited subdirectories. No general objection (though some specific comments below). However I think it would be helpful if you could provid

[Qemu-devel] directory hierarchy

2012-09-14 Thread Paolo Bonzini
Hi all, here is a proposal for moving around 150 C files currently in the toplevel directory to separate, well-delimited subdirectories. Header files would be moved for now in include/, preparing for subsequent reorganization of headers. Usually the files would keep their names, but I loathe nam