Re: [Qemu-devel] checkpatch.pl false positive: wants braces on #if

2011-02-25 Thread Blue Swirl
On Wed, Feb 23, 2011 at 6:07 PM, Peter Maydell wrote: > If you run checkpatch.pl on this patch: > http://patchwork.ozlabs.org/patch/84189/ > > it complains: > WARNING: braces {} are necessary even for single statement blocks > #29: FILE: tcg/tcg.c:454: > +#if defined(CONFIG_DEBUG_TCG) > +    s->te

[Qemu-devel] checkpatch.pl false positive: wants braces on #if

2011-02-23 Thread Peter Maydell
If you run checkpatch.pl on this patch: http://patchwork.ozlabs.org/patch/84189/ it complains: WARNING: braces {} are necessary even for single statement blocks #29: FILE: tcg/tcg.c:454: +#if defined(CONFIG_DEBUG_TCG) +s->temps_in_use++; ...but braces on a cpp conditional are a bit tricky :-