Re: [Qemu-devel] backup notifier fail policy

2016-10-05 Thread Stefan Hajnoczi
On Wed, Oct 05, 2016 at 10:12:57AM +0200, Kevin Wolf wrote: > Am 04.10.2016 um 18:02 hat Stefan Hajnoczi geschrieben: > > On Tue, Oct 04, 2016 at 01:55:30PM +0200, Kevin Wolf wrote: > > > Am 04.10.2016 um 12:41 hat Denis V. Lunev geschrieben: > > > > On 10/04/2016 12:34 PM, Kevin Wolf wrote: > > >

Re: [Qemu-devel] backup notifier fail policy

2016-10-05 Thread Kevin Wolf
Am 04.10.2016 um 18:02 hat Stefan Hajnoczi geschrieben: > On Tue, Oct 04, 2016 at 01:55:30PM +0200, Kevin Wolf wrote: > > Am 04.10.2016 um 12:41 hat Denis V. Lunev geschrieben: > > > On 10/04/2016 12:34 PM, Kevin Wolf wrote: > > > > Am 04.10.2016 um 11:23 hat Stefan Hajnoczi geschrieben: > > > >> O

Re: [Qemu-devel] backup notifier fail policy

2016-10-04 Thread Denis V. Lunev
On 10/04/2016 07:03 PM, John Snow wrote: > > > On 10/04/2016 12:02 PM, Stefan Hajnoczi wrote: >> On Tue, Oct 04, 2016 at 01:55:30PM +0200, Kevin Wolf wrote: >>> Am 04.10.2016 um 12:41 hat Denis V. Lunev geschrieben: On 10/04/2016 12:34 PM, Kevin Wolf wrote: > Am 04.10.2016 um 11:23 hat Ste

Re: [Qemu-devel] backup notifier fail policy

2016-10-04 Thread Stefan Hajnoczi
On Tue, Oct 04, 2016 at 01:55:30PM +0200, Kevin Wolf wrote: > Am 04.10.2016 um 12:41 hat Denis V. Lunev geschrieben: > > On 10/04/2016 12:34 PM, Kevin Wolf wrote: > > > Am 04.10.2016 um 11:23 hat Stefan Hajnoczi geschrieben: > > >> On Mon, Oct 03, 2016 at 02:07:34PM -0400, John Snow wrote: > > >>>

Re: [Qemu-devel] backup notifier fail policy

2016-10-04 Thread John Snow
On 10/04/2016 12:02 PM, Stefan Hajnoczi wrote: On Tue, Oct 04, 2016 at 01:55:30PM +0200, Kevin Wolf wrote: Am 04.10.2016 um 12:41 hat Denis V. Lunev geschrieben: On 10/04/2016 12:34 PM, Kevin Wolf wrote: Am 04.10.2016 um 11:23 hat Stefan Hajnoczi geschrieben: On Mon, Oct 03, 2016 at 02:07:3

Re: [Qemu-devel] backup notifier fail policy

2016-10-04 Thread Denis V. Lunev
On 10/04/2016 12:34 PM, Kevin Wolf wrote: > Am 04.10.2016 um 11:23 hat Stefan Hajnoczi geschrieben: >> On Mon, Oct 03, 2016 at 02:07:34PM -0400, John Snow wrote: >>> >>> On 10/03/2016 09:11 AM, Stefan Hajnoczi wrote: On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] backup notifier fail policy

2016-10-04 Thread Kevin Wolf
Am 04.10.2016 um 12:41 hat Denis V. Lunev geschrieben: > On 10/04/2016 12:34 PM, Kevin Wolf wrote: > > Am 04.10.2016 um 11:23 hat Stefan Hajnoczi geschrieben: > >> On Mon, Oct 03, 2016 at 02:07:34PM -0400, John Snow wrote: > >>> > >>> On 10/03/2016 09:11 AM, Stefan Hajnoczi wrote: > On Fri, Se

Re: [Qemu-devel] backup notifier fail policy

2016-10-04 Thread Kevin Wolf
Am 04.10.2016 um 11:23 hat Stefan Hajnoczi geschrieben: > On Mon, Oct 03, 2016 at 02:07:34PM -0400, John Snow wrote: > > > > > > On 10/03/2016 09:11 AM, Stefan Hajnoczi wrote: > > > On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy > > > wrote: > > > > On 30.09.2016 20:11, V

Re: [Qemu-devel] backup notifier fail policy

2016-10-04 Thread Stefan Hajnoczi
On Mon, Oct 03, 2016 at 02:07:34PM -0400, John Snow wrote: > > > On 10/03/2016 09:11 AM, Stefan Hajnoczi wrote: > > On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: > > > > Hi all! > > > > > > > > Pl

Re: [Qemu-devel] backup notifier fail policy

2016-10-03 Thread John Snow
On 10/03/2016 09:11 AM, Stefan Hajnoczi wrote: On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: Hi all! Please, can somebody explain me, why we fail guest request in case of io error in write notifier? I th

Re: [Qemu-devel] backup notifier fail policy

2016-10-03 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > Please, can somebody explain me, why we fail guest request in case of io > > error in write notifier? I think guest consistency is more impor

Re: [Qemu-devel] backup notifier fail policy

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: Hi all! Please, can somebody explain me, why we fail guest request in case of io error in write notifier? I think guest consistency is more important than success of unfinished backup. Or, what am I missing? I'm saying about this code:

[Qemu-devel] backup notifier fail policy

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Hi all! Please, can somebody explain me, why we fail guest request in case of io error in write notifier? I think guest consistency is more important than success of unfinished backup. Or, what am I missing? I'm saying about this code: static int coroutine_fn backup_before_write_notify(