Re: [Qemu-devel] Virtual VFAT with floppy option doesn't work

2014-03-28 Thread Markus Armbruster
Kiyokazu SUTO writes: > Citation (with leading "> " of each line) from article: > <8761mzq0wl@blackfin.pond.sub.org> > by Markus Armbruster : >> Your fix is correct, but the patch doesn't pass checkpatch, it doesn't >> have a proper commit message, and it lacks your S-o-B. Since the f

Re: [Qemu-devel] Virtual VFAT with floppy option doesn't work

2014-03-27 Thread Kiyokazu SUTO
Citation (with leading "> " of each line) from article: <8761mzq0wl@blackfin.pond.sub.org> by Markus Armbruster : > Your fix is correct, but the patch doesn't pass checkpatch, it doesn't > have a proper commit message, and it lacks your S-o-B. Since the fix is > trivial, and we're very

Re: [Qemu-devel] Virtual VFAT with floppy option doesn't work

2014-03-27 Thread Markus Armbruster
Kiyokazu SUTO writes: > Hi, > > Virtual VFAT mechanism in recent releases does not work with the > floppy option, because, in `vvfat_open()' function, the member > `first_sectors_number' is overwritten with the value for HDD even when > the floppy option presents. I attach the diff output just t

[Qemu-devel] Virtual VFAT with floppy option doesn't work

2014-01-06 Thread Kiyokazu SUTO
Hi, Virtual VFAT mechanism in recent releases does not work with the floppy option, because, in `vvfat_open()' function, the member `first_sectors_number' is overwritten with the value for HDD even when the floppy option presents. I attach the diff output just to clarify the problem. Sorry if th