Re: [Qemu-devel] Use getaddrinfo for migration

2012-03-05 Thread Amos Kong
On 02/03/12 18:41, Daniel P. Berrange wrote: On Fri, Mar 02, 2012 at 02:25:36PM +0400, Michael Tokarev wrote: Not a reply to the patch but a general observation. I noticed that the tcp migration uses gethostname (or getaddrinfo after this patch) from the main thread - is it really the way to go

Re: [Qemu-devel] Use getaddrinfo for migration

2012-03-02 Thread Daniel P. Berrange
On Fri, Mar 02, 2012 at 02:25:36PM +0400, Michael Tokarev wrote: > Not a reply to the patch but a general observation. > > I noticed that the tcp migration uses gethostname > (or getaddrinfo after this patch) from the main > thread - is it really the way to go? Note that > DNS query which is done

Re: [Qemu-devel] Use getaddrinfo for migration

2012-03-02 Thread Michael Tokarev
Not a reply to the patch but a general observation. I noticed that the tcp migration uses gethostname (or getaddrinfo after this patch) from the main thread - is it really the way to go? Note that DNS query which is done may block for a large amount of time. Is it really safe in this context? S