Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit.

2011-09-21 Thread Brad
On 21/09/11 5:21 AM, Paolo Bonzini wrote: On 09/21/2011 09:43 AM, Brad wrote: It is not portable code, and (unlike the rest of qemu-nbd and the block/nbd.c protocol) not meant to be portable. Are BLKROSET (defined in linux/fs.h) and the whole set of NBD ioctls available under OpenBSD? Ok. What

Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit.

2011-09-21 Thread Paolo Bonzini
On 09/21/2011 09:43 AM, Brad wrote: >> It is not portable code, and (unlike the rest of qemu-nbd and the >> block/nbd.c protocol) not meant to be portable. Are BLKROSET (defined in >> linux/fs.h) and the whole set of NBD ioctls available under OpenBSD? > > Ok. What confused me a bit is that partic

Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit.

2011-09-21 Thread Brad
On 21/09/11 3:32 AM, Paolo Bonzini wrote: On 09/21/2011 09:27 AM, Brad wrote: Besides the obvious issue.. nbd.c:443: error: conflicting types for 'nbd_init' nbd.h:71: error: previous declaration of 'nbd_init' was here Oops, thanks for pointing it out to me. The changing of #ifndef _WIN32 to

Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit.

2011-09-21 Thread Kevin Wolf
Am 21.09.2011 09:32, schrieb Paolo Bonzini: > On 09/21/2011 09:27 AM, Brad wrote: >> Besides the obvious issue.. >> >> nbd.c:443: error: conflicting types for 'nbd_init' >> nbd.h:71: error: previous declaration of 'nbd_init' was here > > Oops, thanks for pointing it out to me. Can you please send

Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit.

2011-09-21 Thread Paolo Bonzini
On 09/21/2011 09:27 AM, Brad wrote: Besides the obvious issue.. nbd.c:443: error: conflicting types for 'nbd_init' nbd.h:71: error: previous declaration of 'nbd_init' was here Oops, thanks for pointing it out to me. The changing of #ifndef _WIN32 to #ifdef __linux__ in nbd.c also looks quest

[Qemu-devel] Tree broken by nbd: support feature negotiation commit.

2011-09-21 Thread Brad
The following commit.. nbd: support feature negotiation nbd supports writing flags in bytes 24...27 of the header, and uses that for the read-only flag. Add support for it in qemu-nbd. breaks the tree on what looks like anything but Linux. Besides the obvious issue.. nbd.c:443: error: confli