Re: [Qemu-devel] Subject: Re: [PATCH] hw/block/nvme

2019-09-12 Thread Stefan Hajnoczi
On Tue, Sep 10, 2019 at 11:23:50PM +0300, Toe Dev wrote: > Hey, > While reviewing I noticed maybe we need to update the spec revision. > In: nvme_class_init(...) > > current code pc->revision=2 > change to: pc->revision=3 > However not really important I think.. Just for consistency. > When I don

[Qemu-devel] Subject: Re: [PATCH] hw/block/nvme

2019-09-10 Thread Toe Dev
Hey, While reviewing I noticed maybe we need to update the spec revision. In: nvme_class_init(...) current code pc->revision=2 change to: pc->revision=3 However not really important I think.. Just for consistency. When I done reviewing, should it be patched too, How?