Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 04.12.2014 um 20:44 hat Eric Blake geschrieben: >> On 12/04/2014 08:56 AM, Markus Armbruster wrote: >> >> > >> > @device is a sub-optimal name for this single parameter. Either we >> > accept that and move on, or we deprecate it in favor of a new parameter >> > with a b

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 05.12.2014 um 10:34 hat Markus Armbruster geschrieben: >> Eric Blake writes: >> >> > On 12/04/2014 08:56 AM, Markus Armbruster wrote: >> > >> >> >> >> @device is a sub-optimal name for this single parameter. Either we >> >> accept that and move on, or we deprecate it i

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-05 Thread Kevin Wolf
Am 05.12.2014 um 10:34 hat Markus Armbruster geschrieben: > Eric Blake writes: > > > On 12/04/2014 08:56 AM, Markus Armbruster wrote: > > > >> > >> @device is a sub-optimal name for this single parameter. Either we > >> accept that and move on, or we deprecate it in favor of a new parameter > >

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-05 Thread Markus Armbruster
Eric Blake writes: > On 12/04/2014 08:56 AM, Markus Armbruster wrote: > >> >> @device is a sub-optimal name for this single parameter. Either we >> accept that and move on, or we deprecate it in favor of a new parameter >> with a better name. I guess the better name isn't worth that much >> tr

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-05 Thread Kevin Wolf
Am 04.12.2014 um 20:44 hat Eric Blake geschrieben: > On 12/04/2014 08:56 AM, Markus Armbruster wrote: > > > > > @device is a sub-optimal name for this single parameter. Either we > > accept that and move on, or we deprecate it in favor of a new parameter > > with a better name. I guess the bett

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-04 Thread Eric Blake
On 12/04/2014 08:56 AM, Markus Armbruster wrote: > > @device is a sub-optimal name for this single parameter. Either we > accept that and move on, or we deprecate it in favor of a new parameter > with a better name. I guess the better name isn't worth that much > trouble, in particular since th

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-04 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 12/03/2014 03:30 AM, Kevin Wolf wrote: >>> [ CCed Benoît and Max, this is blockdev work ] >>> [ CCed Jeff, we're also talking about op blockers ] >>> >>> Not stripping quoted text for their convenience. >> >> I still intend to go through th

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-04 Thread Markus Armbruster
Fam Zheng writes: > On Tue, 12/02 20:06, Markus Armbruster wrote: >> == block-core.json == >> >> * block-commit >> >> @device names a backend, @top and @base each name one of its nodes via >> file name matching. >> >> TODO: support specifying the two nodes via node name. >> >> Why do

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-04 Thread Markus Armbruster
Kevin Wolf writes: > [ CCed Benoît and Max, this is blockdev work ] > [ CCed Jeff, we're also talking about op blockers ] > > Not stripping quoted text for their convenience. > > Am 02.12.2014 um 20:06 hat Markus Armbruster geschrieben: >> = Introduction = >> >> The block layer and its monitor c

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-03 Thread Markus Armbruster
Eric Blake writes: > On 12/03/2014 03:30 AM, Kevin Wolf wrote: >> [ CCed Benoît and Max, this is blockdev work ] >> [ CCed Jeff, we're also talking about op blockers ] >> >> Not stripping quoted text for their convenience. > > I still intend to go through this mail in more detail, but off of a >

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-03 Thread Eric Blake
On 12/03/2014 03:30 AM, Kevin Wolf wrote: > [ CCed Benoît and Max, this is blockdev work ] > [ CCed Jeff, we're also talking about op blockers ] > > Not stripping quoted text for their convenience. I still intend to go through this mail in more detail, but off of a quick glance, I see you missed

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-03 Thread Paolo Bonzini
On 03/12/2014 06:52, Fam Zheng wrote: >> > * drive-backup >> > >> > @device names a backend. >> > >> > Do we want to be able to back up any node, or only a backend? If non-backend nodes are read-only, we can just copy them outside QEMU. >> > Note: documentation of @target sounds like it

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-03 Thread Kevin Wolf
[ CCed Benoît and Max, this is blockdev work ] [ CCed Jeff, we're also talking about op blockers ] Not stripping quoted text for their convenience. Am 02.12.2014 um 20:06 hat Markus Armbruster geschrieben: > = Introduction = > > The block layer and its monitor commands have evolved, resulting in

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-02 Thread Fam Zheng
On Tue, 12/02 20:06, Markus Armbruster wrote: > == block-core.json == > > * block-commit > > @device names a backend, @top and @base each name one of its nodes via > file name matching. > > TODO: support specifying the two nodes via node name. > > Why do we need @device when a top node

[Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-02 Thread Markus Armbruster
= Introduction = The block layer and its monitor commands have evolved, resulting in a bit of a mess when it comes to referring to block layer objects in commands. Semantically, we refer to two different kinds of objects: backends and nodes within backends. Example: eject parameter @device names