Re: [Qemu-devel] Restore consistent formatting

2012-02-11 Thread Andreas Färber
Am 11.02.2012 10:19, schrieb Blue Swirl: > On Wed, Feb 8, 2012 at 15:36, Andreas Färber wrote: >> This is not about whether or not we put a space somewhere. >> >> It's about reviewers and SubmitAPatch telling people to run >> checkpatch.pl on patches and checkpatch.pl reporting this as an ERROR, >

Re: [Qemu-devel] Restore consistent formatting

2012-02-11 Thread Blue Swirl
On Wed, Feb 8, 2012 at 15:36, Andreas Färber wrote: > Am 08.02.2012 16:23, schrieb Anthony Liguori: >> On 02/08/2012 09:04 AM, malc wrote: >>> On Wed, 8 Feb 2012, Andreas F?rber wrote: >>> Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fi

Re: [Qemu-devel] Restore consistent formatting

2012-02-11 Thread Blue Swirl
On Wed, Feb 8, 2012 at 15:23, Anthony Liguori wrote: > On 02/08/2012 09:04 AM, malc wrote: >> >> On Wed, 8 Feb 2012, Andreas F?rber wrote: >> >>> malc, >>> >>> Arbitrarily reformatting your files is not okay. If you want a different >>> formatting, you need to fix checkpatch.pl first to not error

Re: [Qemu-devel] Restore consistent formatting

2012-02-09 Thread Anthony Liguori
On 02/09/2012 03:48 AM, Markus Armbruster wrote: Anthony Liguori writes: On 02/08/2012 09:04 AM, malc wrote: On Wed, 8 Feb 2012, Andreas F?rber wrote: malc, Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to not error

Re: [Qemu-devel] Restore consistent formatting

2012-02-09 Thread Markus Armbruster
Anthony Liguori writes: > On 02/08/2012 09:04 AM, malc wrote: >> On Wed, 8 Feb 2012, Andreas F?rber wrote: >> >>> malc, >>> >>> Arbitrarily reformatting your files is not okay. If you want a different >>> formatting, you need to fix checkpatch.pl first to not error on that >>> formatting in your

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Anthony Liguori
On 02/08/2012 09:36 AM, Andreas Färber wrote: Am 08.02.2012 16:23, schrieb Anthony Liguori: On 02/08/2012 09:04 AM, malc wrote: On Wed, 8 Feb 2012, Andreas F?rber wrote: Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Andreas Färber
Am 08.02.2012 16:23, schrieb Anthony Liguori: > On 02/08/2012 09:04 AM, malc wrote: >> On Wed, 8 Feb 2012, Andreas F?rber wrote: >> >>> Arbitrarily reformatting your files is not okay. If you want a different >>> formatting, you need to fix checkpatch.pl first to not error on that >>> formatting in

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Andreas Färber
Am 08.02.2012 16:04, schrieb malc: > On Wed, 8 Feb 2012, Andreas F?rber wrote: > >> Arbitrarily reformatting your files is not okay. If you want a different >> formatting, you need to fix checkpatch.pl first to not error on that >> formatting in your files. > > It was always formatter like this (

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Anthony Liguori
On 02/08/2012 09:04 AM, malc wrote: On Wed, 8 Feb 2012, Andreas F?rber wrote: malc, Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to not error on that formatting in your files. It was always formatter like this (inter

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread malc
On Wed, 8 Feb 2012, Andreas F?rber wrote: > malc, > > Arbitrarily reformatting your files is not okay. If you want a different > formatting, you need to fix checkpatch.pl first to not error on that > formatting in your files. It was always formatter like this (internally consistent), then others

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Andreas Färber
malc, Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to not error on that formatting in your files. And please post your patches to the mailing list. Thanks, Andreas Am 08.02.2012 11:11, schrieb Evgeny Voevodin: > The las

[Qemu-devel] Restore consistent formatting

2012-02-08 Thread Evgeny Voevodin
The last commit "Restore consistent formatting" (cf4dc461a4cfc3e056ee24edb26154f4d34a6278) which is on the master but absent in mailing list results in such output of checkpatch.pl: ./scripts/checkpatch.pl --no-tree --file hw/cs4231a.c ... total: 107 errors, 88 warnings, 696 lines checked