[Qemu-devel] Re: virtio_blk_load() question

2010-03-18 Thread OHMURA Kei
On 2010/03/18 21:07, Juan Quintela wrote: Really, ordering doesn't matter (in this case): see virtio-blk.c:virtio_blk_dma_restart_bh() QLIST_FOREACH_SAFE(req, &rq_copy, next, next_req) { QLIST_REMOVE(req, next); virtio_blk_handle_request(req, &mrb); } This mean that we

[Qemu-devel] Re: virtio_blk_load() question

2010-03-18 Thread Juan Quintela
OHMURA Kei wrote: > Thanks for your reply. > >> When I ported virtio to vmstate, I was unable to get that list not empty >> for more than I tried. It should be not empty in the case of one error >> or similar, but I was not able to reproduce it. > > Actually, I wasn't able to get that condition e

[Qemu-devel] Re: virtio_blk_load() question

2010-03-18 Thread OHMURA Kei
Thanks for your reply. When I ported virtio to vmstate, I was unable to get that list not empty for more than I tried. It should be not empty in the case of one error or similar, but I was not able to reproduce it. Actually, I wasn't able to get that condition either. We're having problem in

[Qemu-devel] Re: virtio_blk_load() question

2010-03-18 Thread Juan Quintela
OHMURA Kei wrote: > Hi, > > I have a question regarding virtio_blk_load(). > (qemu-kvm.git d1fa468c1cc03ea362d8fe3ed9269bab4d197510) > > VirtIOBlockReq structure is linked list of requests, but it doesn't seem to be > properly linked in virtio_blk_load(). > ... > req->next = s->rq; > s->rq = req->