Re: [Qemu-devel] Re: [sneak preview] major scsi overhaul

2009-11-12 Thread Hannes Reinecke
Gerd Hoffmann wrote: > On 11/11/09 14:30, Hannes Reinecke wrote: >> Gerd Hoffmann wrote: >>> How about sticking a 'void *hba_private' element into SCSIRequest >>> instead? >>> >> Would work for me, too. > > Pushed (scsi.v7 now). > Okay, I've converted the driver. Works so far. One minor nitpick,

Re: [Qemu-devel] Re: [sneak preview] major scsi overhaul

2009-11-11 Thread Gerd Hoffmann
On 11/11/09 14:30, Hannes Reinecke wrote: Gerd Hoffmann wrote: How about sticking a 'void *hba_private' element into SCSIRequest instead? Would work for me, too. Pushed (scsi.v7 now). cheers, Gerd

Re: [Qemu-devel] Re: [sneak preview] major scsi overhaul

2009-11-11 Thread Hannes Reinecke
Gerd Hoffmann wrote: > On 11/11/09 12:52, Hannes Reinecke wrote: >> I still don't quite agree with the new scsi callback, which has >> just the SCSIRequest as an argument. So when supporting more command >> queueing we have no idea to which (internal) request structure >> the SCSIRequest belongs, a

Re: [Qemu-devel] Re: [sneak preview] major scsi overhaul

2009-11-11 Thread Gerd Hoffmann
On 11/11/09 12:52, Hannes Reinecke wrote: I still don't quite agree with the new scsi callback, which has just the SCSIRequest as an argument. So when supporting more command queueing we have no idea to which (internal) request structure the SCSIRequest belongs, and still have to do a lookup. Whi

Re: [Qemu-devel] Re: [sneak preview] major scsi overhaul

2009-11-11 Thread Hannes Reinecke
Gerd Hoffmann wrote: > On 11/07/09 00:09, Gerd Hoffmann wrote: >> Hi, >> >> http://repo.or.cz/w/qemu/kraxel.git/shortlog/refs/heads/scsi.v6 > > Pushed an update, same branch. > >> What needs to be done? >> >> (1) Better patch descriptions. >> (2) Submit patches to the list for review. > > Stil

[Qemu-devel] Re: [sneak preview] major scsi overhaul

2009-11-11 Thread Gerd Hoffmann
On 11/07/09 00:09, Gerd Hoffmann wrote: Hi, http://repo.or.cz/w/qemu/kraxel.git/shortlog/refs/heads/scsi.v6 Pushed an update, same branch. What needs to be done? (1) Better patch descriptions. (2) Submit patches to the list for review. Still to do. Also: - fold incremental fixes into