[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2011-01-05 Thread Kevin O'Connor
On Wed, Jan 05, 2011 at 01:10:08PM +0200, Gleb Natapov wrote: > On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: > > Use _RMV method to indicate whether device can be removed. > > > > Data is retrieved from QEMU via I/O port 0xae0c. > > > > Signed-off-by: Marcelo Tosatti > > > A

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-20 Thread Marcelo Tosatti
On Mon, Dec 20, 2010 at 07:44:12PM +0200, Avi Kivity wrote: > On 12/20/2010 07:05 PM, Marcelo Tosatti wrote: > >> > > >> >Yes, perhaps it all (including PCI hotplug controller) should be using > >> >something else than hardcoded IO ports, but thats what we have now. > >> > >> At least it should

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-20 Thread Marcelo Tosatti
On Mon, Dec 20, 2010 at 11:15:40AM +0200, Avi Kivity wrote: > On 12/20/2010 10:49 AM, Marcelo Tosatti wrote: > >On Sun, Dec 12, 2010 at 02:57:45PM -0500, Kevin O'Connor wrote: > >> On Sun, Dec 12, 2010 at 09:49:16PM +0200, Gleb Natapov wrote: > >> > On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevi

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-20 Thread Avi Kivity
On 12/20/2010 07:05 PM, Marcelo Tosatti wrote: > > > >Yes, perhaps it all (including PCI hotplug controller) should be using > >something else than hardcoded IO ports, but thats what we have now. > > At least it should be documented. > > What's the behaviour with a qemu that doesn't support

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-20 Thread Avi Kivity
On 12/20/2010 10:49 AM, Marcelo Tosatti wrote: On Sun, Dec 12, 2010 at 02:57:45PM -0500, Kevin O'Connor wrote: > On Sun, Dec 12, 2010 at 09:49:16PM +0200, Gleb Natapov wrote: > > On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote: > > > On Wed, Dec 08, 2010 at 03:08:59PM -0200,

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-20 Thread Marcelo Tosatti
On Sun, Dec 12, 2010 at 02:57:45PM -0500, Kevin O'Connor wrote: > On Sun, Dec 12, 2010 at 09:49:16PM +0200, Gleb Natapov wrote: > > On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote: > > > On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: > > > > Use _RMV method to indic

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-13 Thread Gleb Natapov
On Mon, Dec 13, 2010 at 11:10:38AM +0200, Avi Kivity wrote: > On 12/13/2010 11:03 AM, Gleb Natapov wrote: > >> We could also deprecate the old port and use fwcfg for everything > >> (try fwcfg, fall back to ae00). > >> > >fwcfg designed to be simple for easy use by firmware. It has two port > >on

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-13 Thread Avi Kivity
On 12/13/2010 11:03 AM, Gleb Natapov wrote: > We could also deprecate the old port and use fwcfg for everything > (try fwcfg, fall back to ae00). > fwcfg designed to be simple for easy use by firmware. It has two port one for index another for value, so its use is racy in multi-threaded SMP env

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-13 Thread Gleb Natapov
On Mon, Dec 13, 2010 at 10:53:07AM +0200, Avi Kivity wrote: > On 12/13/2010 10:49 AM, Gleb Natapov wrote: > >On Mon, Dec 13, 2010 at 10:41:25AM +0200, Avi Kivity wrote: > >> On 12/13/2010 02:00 AM, Marcelo Tosatti wrote: > >> >On Sat, Dec 11, 2010 at 09:39:30AM +0200, Avi Kivity wrote: > >> >>

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-13 Thread Avi Kivity
On 12/13/2010 10:49 AM, Gleb Natapov wrote: On Mon, Dec 13, 2010 at 10:41:25AM +0200, Avi Kivity wrote: > On 12/13/2010 02:00 AM, Marcelo Tosatti wrote: > >On Sat, Dec 11, 2010 at 09:39:30AM +0200, Avi Kivity wrote: > >> On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: > >> >Use _RMV method

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-13 Thread Gleb Natapov
On Mon, Dec 13, 2010 at 10:41:25AM +0200, Avi Kivity wrote: > On 12/13/2010 02:00 AM, Marcelo Tosatti wrote: > >On Sat, Dec 11, 2010 at 09:39:30AM +0200, Avi Kivity wrote: > >> On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: > >> >Use _RMV method to indicate whether device can be removed. > >> >

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-13 Thread Avi Kivity
On 12/13/2010 02:00 AM, Marcelo Tosatti wrote: On Sat, Dec 11, 2010 at 09:39:30AM +0200, Avi Kivity wrote: > On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: > >Use _RMV method to indicate whether device can be removed. > > > >Data is retrieved from QEMU via I/O port 0xae0c. > > > > Where did

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-12 Thread Marcelo Tosatti
On Sat, Dec 11, 2010 at 09:39:30AM +0200, Avi Kivity wrote: > On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: > >Use _RMV method to indicate whether device can be removed. > > > >Data is retrieved from QEMU via I/O port 0xae0c. > > > > Where did this port come from? Its the next available addres

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-12 Thread Kevin O'Connor
On Sun, Dec 12, 2010 at 09:49:16PM +0200, Gleb Natapov wrote: > On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote: > > On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: > > > Use _RMV method to indicate whether device can be removed. > > > > > > Data is retrieved from Q

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-12 Thread Gleb Natapov
On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote: > On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: > > Use _RMV method to indicate whether device can be removed. > > > > Data is retrieved from QEMU via I/O port 0xae0c. > > > > Signed-off-by: Marcelo Tosatti > > T

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-12 Thread Kevin O'Connor
On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: > Use _RMV method to indicate whether device can be removed. > > Data is retrieved from QEMU via I/O port 0xae0c. > > Signed-off-by: Marcelo Tosatti Thanks Marcelo, Can you add acked-bys from the qemu/kvm maintaners? -Kevin

[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-10 Thread Avi Kivity
On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Where did this port come from? What's the protocol? Maybe we should do this via fw_cfg. -- I have a truly marvellous patch that fixes t