Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-09 Thread Riku Voipio
> >Actually that patch is not ok. The issues you fix on m68k appear > >on arm/eabi after applying your patch. bswap part appears ok, but > >the padding is needed atleast on arm. > How do you test this patch ? Do you use native gdb on ARM ? Because, for > m68k, cross-compiled gdb does not work (i

Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-09 Thread Laurent Vivier
>On 9 February 2011 09:20, Laurent Vivier wrote: >> It is strange as we have in gdb, if I remember correctly, an explicit check >of the size of prstatus: >> >> gdb/bfd/elf.c: >> >>    if defined (HAVE_PRSTATUS_T) >> >>    static bfd_boolean >>    elfcore_grok_prstatus (bfd *abfd, Elf_Internal_Not

Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-09 Thread Peter Maydell
On 9 February 2011 09:20, Laurent Vivier wrote: > It is strange as we have in gdb, if I remember correctly, an explicit check > of the size of prstatus: > > gdb/bfd/elf.c: > >    if defined (HAVE_PRSTATUS_T) > >    static bfd_boolean >    elfcore_grok_prstatus (bfd *abfd, Elf_Internal_Note *note)

Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-09 Thread Laurent Vivier
>On Sat, Feb 05, 2011 at 10:49:51PM +0100, Laurent Vivier wrote: >> >On 02/03/2011 12:16 PM, Laurent Vivier wrote: >> >> And this one ? >> >> >> >> linux-user: correct core dump format >> >> >> >> http://patchwork.ozlabs.org/patch/78464/ > >Actually that patch is not ok. The issues you fix on m68k

Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-08 Thread Riku Voipio
On Sat, Feb 05, 2011 at 10:49:51PM +0100, Laurent Vivier wrote: > >On 02/03/2011 12:16 PM, Laurent Vivier wrote: > >> And this one ? > >> > >> linux-user: correct core dump format > >> > >> http://patchwork.ozlabs.org/patch/78464/ Actually that patch is not ok. The issues you fix on m68k appear on

Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-07 Thread Anthony Liguori
On 02/05/2011 01:40 PM, riku voipio wrote: On 02/03/2011 12:16 PM, Laurent Vivier wrote: On Wed, Feb 02, 2011 at 08:28:15PM +0100, Stefan Weil wrote: [PATCH] linux-user: Fix possible realloc memory leak (http://patchwork.ozlabs.org/patch/79217/) Looks ok for me. And this one ? linux-user:

Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-05 Thread Laurent Vivier
Hi, I've no need, just put it in your tree where you want... Regards, Laurent riku voipio a écrit : >On 02/03/2011 12:16 PM, Laurent Vivier wrote: >>> On Wed, Feb 02, 2011 at 08:28:15PM +0100, Stefan Weil wrote: [PATCH] linux-user: Fix possible realloc memory leak (http://patchwork.o

Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-05 Thread riku voipio
On 02/03/2011 12:16 PM, Laurent Vivier wrote: On Wed, Feb 02, 2011 at 08:28:15PM +0100, Stefan Weil wrote: [PATCH] linux-user: Fix possible realloc memory leak (http://patchwork.ozlabs.org/patch/79217/) Looks ok for me. And this one ? linux-user: correct core dump format http://patchwork.o

RE: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-03 Thread Laurent Vivier
>On Wed, Feb 02, 2011 at 08:28:15PM +0100, Stefan Weil wrote: >> [PATCH] linux-user: Fix possible realloc memory leak >> (http://patchwork.ozlabs.org/patch/79217/) > >Looks ok for me. And this one ? linux-user: correct core dump format http://patchwork.ozlabs.org/patch/78464/ Laurent -- ---

[Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-02 Thread Riku Voipio
On Wed, Feb 02, 2011 at 08:28:15PM +0100, Stefan Weil wrote: > [PATCH] linux-user: Fix possible realloc memory leak > (http://patchwork.ozlabs.org/patch/79217/) Looks ok for me. Riku

[Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)

2011-02-02 Thread Michael S. Tsirkin
On Wed, Feb 02, 2011 at 08:28:15PM +0100, Stefan Weil wrote: > [PATCH 1/3] pci: Fix memory leak (http://patchwork.ozlabs.org/patch/79996/) Looks good. Pls cc me on patches next time to make sure I do not miss a patch.