[Qemu-devel] Re: [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Luiz Capitulino
On Wed, 30 Dec 2009 15:22:19 +0200 Gleb Natapov wrote: > > > +void do_info_ioapic(Monitor *mon, QObject **ret_data) > > > +{ > > > +int i; > > > +QList *list; > > > + > > > +*ret_data = NULL; > > > + > > > +if (!ioapic) > > > +return; > > > + > > > +list = qlist_new();

[Qemu-devel] Re: [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 11:19:30AM -0200, Luiz Capitulino wrote: > On Wed, 30 Dec 2009 13:50:43 +0200 > Gleb Natapov wrote: > > > I am starring to learn this QObject kung-fu. > > Nice, you really got how to do it. Just two minor comments. > > > One question: > > Why qlist_iter(..., func, ...)

[Qemu-devel] Re: [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Luiz Capitulino
On Wed, 30 Dec 2009 13:50:43 +0200 Gleb Natapov wrote: > I am starring to learn this QObject kung-fu. Nice, you really got how to do it. Just two minor comments. > One question: > Why qlist_iter(..., func, ...) and not > FOREACH_QOBJ() { >do things > } Well, when I started working on t