[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-07 Thread Gleb Natapov
On Sun, Mar 07, 2010 at 02:44:50PM +0100, Jan Kiszka wrote: > Jan Kiszka wrote: > > Gleb Natapov wrote: > >> On Thu, Mar 04, 2010 at 02:03:54PM +0200, Gleb Natapov wrote: > BTW, do real systems allow to hot plug BSP as well? Or how is the case > handled when you unplug the BSP and then re

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-07 Thread Jan Kiszka
Jan Kiszka wrote: > Gleb Natapov wrote: >> On Thu, Mar 04, 2010 at 02:03:54PM +0200, Gleb Natapov wrote: BTW, do real systems allow to hot plug BSP as well? Or how is the case handled when you unplug the BSP and then reboot the box? >>> Did you mean hot unplug BSP? OS determines what

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-07 Thread Jan Kiszka
Gleb Natapov wrote: > On Thu, Mar 04, 2010 at 02:03:54PM +0200, Gleb Natapov wrote: >>> BTW, do real systems allow to hot plug BSP as well? Or how is the case >>> handled when you unplug the BSP and then reboot the box? >>> >> Did you mean hot unplug BSP? OS determines what CPU is BSP by checking >

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-06 Thread Gleb Natapov
On Thu, Mar 04, 2010 at 02:03:54PM +0200, Gleb Natapov wrote: > > BTW, do real systems allow to hot plug BSP as well? Or how is the case > > handled when you unplug the BSP and then reboot the box? > > > Did you mean hot unplug BSP? OS determines what CPU is BSP by checking > BSP bit in APIC base

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-04 Thread Gleb Natapov
On Thu, Mar 04, 2010 at 12:35:45PM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Thu, Mar 04, 2010 at 09:23:46AM +0100, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Mon, Mar 01, 2010 at 06:

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-04 Thread Jan Kiszka
Gleb Natapov wrote: > On Thu, Mar 04, 2010 at 09:23:46AM +0100, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote: Gleb Natapov wrote: > On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: >> As we hard-wire the BSP to CPU 0

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-04 Thread Gleb Natapov
On Thu, Mar 04, 2010 at 09:23:46AM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: > As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-04 Thread Jan Kiszka
Gleb Natapov wrote: > On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals cpu_index, cpu_is_bsp can also be based on the latter d

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-03 Thread Gleb Natapov
On Thu, Mar 04, 2010 at 12:34:22AM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: > >> As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals > >> cpu_index, cpu_is_bsp can also be based on the latter directly. This > >> will

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-03 Thread Jan Kiszka
Gleb Natapov wrote: > On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: >> As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals >> cpu_index, cpu_is_bsp can also be based on the latter directly. This >> will help an early user of it: KVM while initializing mp_state. >> >> Sign

[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-03 Thread Gleb Natapov
On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote: > As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals > cpu_index, cpu_is_bsp can also be based on the latter directly. This > will help an early user of it: KVM while initializing mp_state. > > Signed-off-by: Jan Kiszka > -