[Qemu-devel] Re: [PATCH v3] savevm: Really verify if a drive supports snapshots

2010-06-04 Thread Miguel Di Ciurcio Filho
On Fri, Jun 4, 2010 at 2:28 PM, Kevin Wolf wrote: >> @@ -1674,12 +1659,26 @@ void do_savevm(Monitor *mon, const QDict *qdict) >>  #endif >>      const char *name = qdict_get_try_str(qdict, "name"); >> >> +    /* Verify if there is a device that doesn't support snapshots and is >> writable */ >> +

[Qemu-devel] Re: [PATCH v3] savevm: Really verify if a drive supports snapshots

2010-06-04 Thread Kevin Wolf
Am 03.06.2010 21:52, schrieb Miguel Di Ciurcio Filho: > Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. > > First issue: Their names implies different porpouses, but they do the same > thing > and have exactly the same code. Maybe copied and pasted and forgotten? > b

[Qemu-devel] Re: [PATCH v3] savevm: Really verify if a drive supports snapshots

2010-06-04 Thread Kevin Wolf
Am 03.06.2010 21:52, schrieb Miguel Di Ciurcio Filho: > Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. > > First issue: Their names implies different porpouses, but they do the same > thing > and have exactly the same code. Maybe copied and pasted and forgotten? > b