Re: [Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-13 Thread Gleb Natapov
On Tue, Jul 13, 2010 at 02:11:10PM +0300, Michael S. Tsirkin wrote: > On Tue, Jul 13, 2010 at 09:35:49AM +0300, Gleb Natapov wrote: > > On Mon, Jul 12, 2010 at 06:00:20PM -0500, Anthony Liguori wrote: > > > On 07/12/2010 05:42 PM, Michael S. Tsirkin wrote: > > > >On Mon, Jul 12, 2010 at 04:07:21PM

Re: [Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-13 Thread Michael S. Tsirkin
On Tue, Jul 13, 2010 at 09:35:49AM +0300, Gleb Natapov wrote: > On Mon, Jul 12, 2010 at 06:00:20PM -0500, Anthony Liguori wrote: > > On 07/12/2010 05:42 PM, Michael S. Tsirkin wrote: > > >On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: > > >>On 07/12/2010 12:48 PM, Michael S. Tsirk

Re: [Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Gleb Natapov
On Mon, Jul 12, 2010 at 06:00:20PM -0500, Anthony Liguori wrote: > On 07/12/2010 05:42 PM, Michael S. Tsirkin wrote: > >On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: > >>On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: > >>>We do range check for size, and get size as buffer, > >

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Anthony Liguori
On 07/12/2010 05:42 PM, Michael S. Tsirkin wrote: On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: We do range check for size, and get size as buffer, but copy size + 4 bytes (4 is for FCS). Let's copy size bytes but pu

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Michael S. Tsirkin
On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: > On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: > >We do range check for size, and get size as buffer, > >but copy size + 4 bytes (4 is for FCS). > >Let's copy size bytes but put size + 4 in length. > > > >Signed-off-by: Michael S

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Anthony Liguori
On 07/12/2010 04:30 PM, Michael S. Tsirkin wrote: On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: We do range check for size, and get size as buffer, but copy size + 4 bytes (4 is for FCS). Let's copy size bytes but pu

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Michael S. Tsirkin
On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: > On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: > >We do range check for size, and get size as buffer, > >but copy size + 4 bytes (4 is for FCS). > >Let's copy size bytes but put size + 4 in length. > > > >Signed-off-by: Michael S

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Anthony Liguori
On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: We do range check for size, and get size as buffer, but copy size + 4 bytes (4 is for FCS). Let's copy size bytes but put size + 4 in length. Signed-off-by: Michael S. Tsirkin I think I'd feel slightly better if we zero'd out the FCS before

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Alex Williamson
On Mon, 2010-07-12 at 20:48 +0300, Michael S. Tsirkin wrote: > We do range check for size, and get size as buffer, > but copy size + 4 bytes (4 is for FCS). > Let's copy size bytes but put size + 4 in length. > > Signed-off-by: Michael S. Tsirkin > --- > > Anthony, Alex, please review. Looks fi