Re: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-22 Thread Edgar E. Iglesias
On Sat, Jan 22, 2011 at 03:40:34PM +0100, Aurelien Jarno wrote: > On Sat, Jan 22, 2011 at 03:32:36PM +0100, Alexander Graf wrote: > > > > On 22.01.2011, at 15:14, Edgar E. Iglesias wrote: > > > > > On Sat, Jan 22, 2011 at 02:13:03PM +0100, Aurelien Jarno wrote: > > >> On Tue, Jan 18, 2011 at 01:5

Re: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-22 Thread Aurelien Jarno
On Sat, Jan 22, 2011 at 03:32:36PM +0100, Alexander Graf wrote: > > On 22.01.2011, at 15:14, Edgar E. Iglesias wrote: > > > On Sat, Jan 22, 2011 at 02:13:03PM +0100, Aurelien Jarno wrote: > >> On Tue, Jan 18, 2011 at 01:58:25PM +0100, Jan Kiszka wrote: > >>> On 2011-01-18 13:05, Alexander Graf wr

Re: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-22 Thread Aurelien Jarno
On Sat, Jan 22, 2011 at 03:28:06PM +0100, Alexander Graf wrote: > > On 22.01.2011, at 14:13, Aurelien Jarno wrote: > > > On Tue, Jan 18, 2011 at 01:58:25PM +0100, Jan Kiszka wrote: > >> On 2011-01-18 13:05, Alexander Graf wrote: > >>> > >>> On 18.01.2011, at 10:08, Gerd Hoffmann wrote: > >>> >

Re: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-22 Thread Alexander Graf
On 22.01.2011, at 15:14, Edgar E. Iglesias wrote: > On Sat, Jan 22, 2011 at 02:13:03PM +0100, Aurelien Jarno wrote: >> On Tue, Jan 18, 2011 at 01:58:25PM +0100, Jan Kiszka wrote: >>> On 2011-01-18 13:05, Alexander Graf wrote: On 18.01.2011, at 10:08, Gerd Hoffmann wrote: > Hi

Re: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-22 Thread Alexander Graf
On 22.01.2011, at 14:13, Aurelien Jarno wrote: > On Tue, Jan 18, 2011 at 01:58:25PM +0100, Jan Kiszka wrote: >> On 2011-01-18 13:05, Alexander Graf wrote: >>> >>> On 18.01.2011, at 10:08, Gerd Hoffmann wrote: >>> Hi, >> Worse might also be that unknown issue that force you to inj

Re: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-22 Thread Edgar E. Iglesias
On Sat, Jan 22, 2011 at 02:13:03PM +0100, Aurelien Jarno wrote: > On Tue, Jan 18, 2011 at 01:58:25PM +0100, Jan Kiszka wrote: > > On 2011-01-18 13:05, Alexander Graf wrote: > > > > > > On 18.01.2011, at 10:08, Gerd Hoffmann wrote: > > > > > >> Hi, > > >> > > Worse might also be that unknown

Re: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-22 Thread Aurelien Jarno
On Tue, Jan 18, 2011 at 01:58:25PM +0100, Jan Kiszka wrote: > On 2011-01-18 13:05, Alexander Graf wrote: > > > > On 18.01.2011, at 10:08, Gerd Hoffmann wrote: > > > >> Hi, > >> > Worse might also be that unknown issue that force you to inject an IRQ > here. We don't know. That's probab

Re: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-18 Thread Gerd Hoffmann
Hi, edge triggered interrupts wouldn't though. The code change doesn't change anything for edge triggered interrupts - they work fine. Only !msi (== level) ones are broken. apic irqs can be both edge and level triggered too ... That re-trigger smells like you are not clearing the interru

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-18 Thread Jan Kiszka
On 2011-01-18 13:05, Alexander Graf wrote: > > On 18.01.2011, at 10:08, Gerd Hoffmann wrote: > >> Hi, >> Worse might also be that unknown issue that force you to inject an IRQ here. We don't know. That's probably worst. >>> >>> Well, IIRC the issue was that usually a level high interru

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-18 Thread Alexander Graf
On 18.01.2011, at 10:08, Gerd Hoffmann wrote: > Hi, > >>> Worse might also be that unknown issue that force you to inject an IRQ >>> here. We don't know. That's probably worst. >> >> Well, IIRC the issue was that usually a level high interrupt line would >> simply retrigger an interrupt after

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-18 Thread Gerd Hoffmann
Hi, Worse might also be that unknown issue that force you to inject an IRQ here. We don't know. That's probably worst. Well, IIRC the issue was that usually a level high interrupt line would simply retrigger an interrupt after enabling the interrupt line in the APIC again. edge triggered i

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Alexander Graf
Jan Kiszka wrote: > On 2011-01-17 17:33, Alexander Graf wrote: > >> Jan Kiszka wrote: >> >>> On 2011-01-17 17:04, Alexander Graf wrote: >>> >>> Jan Kiszka wrote: > On 2011-01-17 17:00, Alexander Graf wrote: > > > >>

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Jan Kiszka
On 2011-01-17 17:33, Alexander Graf wrote: > Jan Kiszka wrote: >> On 2011-01-17 17:04, Alexander Graf wrote: >> >>> Jan Kiszka wrote: >>> On 2011-01-17 17:00, Alexander Graf wrote: > Jan Kiszka wrote: > > >> On 2010-12-20 22:13, Alexand

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Alexander Graf
Jan Kiszka wrote: > On 2011-01-17 17:04, Alexander Graf wrote: > >> Jan Kiszka wrote: >> >>> On 2011-01-17 17:00, Alexander Graf wrote: >>> >>> Jan Kiszka wrote: > On 2010-12-20 22:13, Alexander Graf wrote: > > > >>

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Jan Kiszka
On 2011-01-17 17:04, Alexander Graf wrote: > Jan Kiszka wrote: >> On 2011-01-17 17:00, Alexander Graf wrote: >> >>> Jan Kiszka wrote: >>> On 2010-12-20 22:13, Alexander Graf wrote: > When not using MSI, receiving an interrupt while the interrupt line is > a

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Alexander Graf
Jan Kiszka wrote: > On 2011-01-17 17:00, Alexander Graf wrote: > >> Jan Kiszka wrote: >> >>> On 2010-12-20 22:13, Alexander Graf wrote: >>> >>> When not using MSI, receiving an interrupt while the interrupt line is active pulses the interrupt line. Without this, gu

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Jan Kiszka
On 2011-01-17 17:00, Alexander Graf wrote: > Jan Kiszka wrote: >> On 2010-12-20 22:13, Alexander Graf wrote: >> >>> When not using MSI, receiving an interrupt while the interrupt line is >>> active >>> pulses the interrupt line. Without this, guests don't realize that a new >>> interrupt occure

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Alexander Graf
Jan Kiszka wrote: > On 2010-12-20 22:13, Alexander Graf wrote: > >> When not using MSI, receiving an interrupt while the interrupt line is active >> pulses the interrupt line. Without this, guests don't realize that a new >> interrupt occured. >> > > This doesn't look OK. The device model s

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-17 Thread Jan Kiszka
On 2010-12-20 22:13, Alexander Graf wrote: > When not using MSI, receiving an interrupt while the interrupt line is active > pulses the interrupt line. Without this, guests don't realize that a new > interrupt occured. This doesn't look OK. The device model should look at the currently used mode a