[Qemu-devel] Re: [PATCH 7/7] trace: Trace virtqueue operations

2010-05-25 Thread Stefan Hajnoczi
On Tue, May 25, 2010 at 2:52 PM, Avi Kivity wrote: > Hm.  Perhaps we can convert %{type} to %p for backends which don't support > it, and to whatever format they do support for those that do. True. Stefan

[Qemu-devel] Re: [PATCH 7/7] trace: Trace virtqueue operations

2010-05-25 Thread Avi Kivity
On 05/25/2010 04:27 PM, Stefan Hajnoczi wrote: On Tue, May 25, 2010 at 1:04 PM, Avi Kivity wrote: Those %ps are more or less useless. We need better ways of identifying them. You're right, the vq pointer is useless in isolation. We don't know which virtio device or which virtqueue

[Qemu-devel] Re: [PATCH 7/7] trace: Trace virtqueue operations

2010-05-25 Thread Stefan Hajnoczi
On Tue, May 25, 2010 at 1:04 PM, Avi Kivity wrote: > Those %ps are more or less useless.  We need better ways of identifying > them. You're right, the vq pointer is useless in isolation. We don't know which virtio device or which virtqueue number. With the full context of a trace it would be po

[Qemu-devel] Re: [PATCH 7/7] trace: Trace virtqueue operations

2010-05-25 Thread Avi Kivity
On 05/25/2010 01:24 PM, Stefan Hajnoczi wrote: This patch adds trace events for virtqueue operations including adding/removing buffers, notifying the guest, and receiving a notify from the guest. diff --git a/trace-events b/trace-events index 48415f8..a533414 100644 --- a/trace-events +++ b/trac