Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-15 Thread Avi Kivity
On 08/14/2010 12:01 AM, malc wrote: This is all perfectly reasonable, but begs one question, where do we stop codifying self-evident truths (or who is the ultimiate judge of what is self-evident and what isn't), since taking the above to extreme we will end up adding stuff like: you must use cl

[Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-15 Thread Paolo Bonzini
On 08/14/2010 10:52 AM, Andreas Färber wrote: Well, this is not coding style but architectural guide. We could introduce a new document, rename CODING_STYLE or bury this to qemu-tech.texi. But I still (optimistically) think that some kind of READ_ME_BEFORE_CODING would help. I agree that we sh

Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-14 Thread Andreas Färber
Am 14.08.2010 um 12:02 schrieb Blue Swirl: On Fri, Aug 13, 2010 at 9:56 PM, malc wrote: In any case, what i wanted to convey, but failed, is that this doesn't, in my opinion, belong to the CODING_STYLE. Well, this is not coding style but architectural guide. We could introduce a new document

Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-14 Thread Blue Swirl
On Fri, Aug 13, 2010 at 9:56 PM, malc wrote: > On Fri, 13 Aug 2010, Blue Swirl wrote: > >> On Fri, Aug 13, 2010 at 9:01 PM, malc wrote: >> > On Fri, 13 Aug 2010, Blue Swirl wrote: >> > >> >> On Thu, Aug 12, 2010 at 5:50 PM, Blue Swirl wrote: >> >> > Add memory management rules, somewhat like lib

Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-13 Thread malc
On Fri, 13 Aug 2010, Blue Swirl wrote: > On Fri, Aug 13, 2010 at 9:01 PM, malc wrote: > > On Fri, 13 Aug 2010, Blue Swirl wrote: > > > >> On Thu, Aug 12, 2010 at 5:50 PM, Blue Swirl wrote: > >> > Add memory management rules, somewhat like libvirt HACKING. > >> > > >> > Signed-off-by: Blue Swirl

Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-13 Thread Blue Swirl
On Fri, Aug 13, 2010 at 9:01 PM, malc wrote: > On Fri, 13 Aug 2010, Blue Swirl wrote: > >> On Thu, Aug 12, 2010 at 5:50 PM, Blue Swirl wrote: >> > Add memory management rules, somewhat like libvirt HACKING. >> > >> > Signed-off-by: Blue Swirl >> > --- >> >  CODING_STYLE |    8 >> >  1 f

Re: [Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-13 Thread malc
On Fri, 13 Aug 2010, Blue Swirl wrote: > On Thu, Aug 12, 2010 at 5:50 PM, Blue Swirl wrote: > > Add memory management rules, somewhat like libvirt HACKING. > > > > Signed-off-by: Blue Swirl > > --- > >  CODING_STYLE |    8 > >  1 files changed, 8 insertions(+), 0 deletions(-) > > > > di

[Qemu-devel] Re: [PATCH 3/5] CODING_STYLE: add memory management rules

2010-08-13 Thread Blue Swirl
On Thu, Aug 12, 2010 at 5:50 PM, Blue Swirl wrote: > Add memory management rules, somewhat like libvirt HACKING. > > Signed-off-by: Blue Swirl > --- >  CODING_STYLE |    8 >  1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index 3f10d72..08