[Qemu-devel] Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id

2010-02-02 Thread Jan Kiszka
Gleb Natapov wrote: > On Tue, Feb 02, 2010 at 03:20:02PM +0100, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Tue, Feb 02, 2010 at 09:19:06AM +0100, Jan Kiszka wrote: Setting the boot CPU ID is arch-specific KVM stuff. So push it where it belongs to. >>> pc_init1 is also arch-speci

[Qemu-devel] Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id

2010-02-02 Thread Gleb Natapov
On Tue, Feb 02, 2010 at 03:20:02PM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Tue, Feb 02, 2010 at 09:19:06AM +0100, Jan Kiszka wrote: > >> Setting the boot CPU ID is arch-specific KVM stuff. So push it where it > >> belongs to. > >> > > pc_init1 is also arch-specific, no? TCG should als

[Qemu-devel] Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id

2010-02-02 Thread Jan Kiszka
Gleb Natapov wrote: > On Tue, Feb 02, 2010 at 09:19:06AM +0100, Jan Kiszka wrote: >> Setting the boot CPU ID is arch-specific KVM stuff. So push it where it >> belongs to. >> > pc_init1 is also arch-specific, no? TCG should also be able to > have BSP apic_id != 0. But not kvm-specific. I don't un

[Qemu-devel] Re: [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id

2010-02-02 Thread Gleb Natapov
On Tue, Feb 02, 2010 at 09:19:06AM +0100, Jan Kiszka wrote: > Setting the boot CPU ID is arch-specific KVM stuff. So push it where it > belongs to. > pc_init1 is also arch-specific, no? TCG should also be able to have BSP apic_id != 0. > Signed-off-by: Jan Kiszka > --- > hw/pc.c|3 -